Fix #494: Reject a promise on error condition

Also, remove two duplicate unit tests.

Author: nrchandan

integration/test/ParseObjectTest.js

@@ -254,6 +254,16 @@ describe('Parse Object', () => {
     });
   });
 
+  it('cannot set an invalid date', (done) => {
+    let obj = new TestObject();
+    obj.set('when', new Date(Date.parse(null)));
+    Parse.Object.saveAll([obj]).then(() => {
+      done.fail('Expected invalid date to fail');
+    }).fail(() => {
+      done();
+    });
+  });
+
   it('cannot create invalid class names', (done) => {
     let item = new Parse.Object('Foo^Bar');
     item.save().fail((e) => {

src/ParseObject.js

@@ -1847,6 +1847,8 @@ var DefaultController = {
             }, options);
           }).then((response, status, xhr) => {
             batchReturned.resolve(response, status);
+          }, (error) => {
+            batchReturned.reject(new ParseError(error.message));
           });
 
           return ParsePromise.when(batchTasks);

src/__tests__/ParseObject-test.js

@@ -1115,6 +1115,17 @@ describe('ParseObject', () => {
     });
   });
 
+  it('should fail on invalid date', (done) => {
+    var obj = new ParseObject();
+    obj.set('when', new Date(Date.parse(null)));
+    ParseObject.saveAll([obj]).then(() => {
+      done.fail('Expected invalid date to fail');
+    }).fail(() => {
+      done();
+    });
+    jest.runAllTicks();
+  });
+
   it('can save a ring of objects, given one exists', (done) => {
     var xhrs = [];
     RESTController._setXHR(function() {
@@ -1876,66 +1887,6 @@ describe('ParseObject (unique instance mode)', () => {
     expect(o2.get('tags')).toEqual([]);
   });
 
-  it('can save the object', (done) => {
-    CoreManager.getRESTController()._setXHR(
-      mockXHR([{
-        status: 200,
-        response: {
-          objectId: 'P1',
-          count: 1
-        }
-      }])
-    );
-    var p = new ParseObject('Person');
-    p.set('age', 38);
-    p.increment('count');
-    p.save().then((obj) => {
-      expect(obj).toBe(p);
-      expect(obj.get('age')).toBe(38);
-      expect(obj.get('count')).toBe(1);
-      expect(obj.op('age')).toBe(undefined);
-      expect(obj.dirty()).toBe(false);
-      done();
-    });
-  });
-
-  it('can save an array of objects', (done) => {
-    var xhr = {
-      setRequestHeader: jest.genMockFn(),
-      open: jest.genMockFn(),
-      send: jest.genMockFn()
-    };
-    RESTController._setXHR(function() { return xhr; });
-    var objects = [];
-    for (var i = 0; i < 5; i++) {
-      objects[i] = new ParseObject('Person');
-    }
-    ParseObject.saveAll(objects).then(() => {
-      expect(xhr.open.mock.calls[0]).toEqual(
-        ['POST', 'https://api.parse.com/1/batch', true]
-      );
-      expect(JSON.parse(xhr.send.mock.calls[0]).requests[0]).toEqual({
-        method: 'POST',
-        path: '/1/classes/Person',
-        body: {}
-      });
-      done();
-    });
-    jest.runAllTicks();
-
-    xhr.status = 200;
-    xhr.responseText = JSON.stringify([
-      { success: { objectId: 'pid0' } },
-      { success: { objectId: 'pid1' } },
-      { success: { objectId: 'pid2' } },
-      { success: { objectId: 'pid3' } },
-      { success: { objectId: 'pid4' } },
-    ]);
-    xhr.readyState = 4;
-    xhr.onreadystatechange();
-    jest.runAllTicks();
-  });
-
   it('preserves changes when changing the id', () => {
     var o = new ParseObject({
       className: 'Item',