Skip to content

Commit 15bd67e

Browse files
authored
ci: Remove parse server dev dependency (#1796)
* fix: bump node engine to 12.20.0 BREAKING CHANGE Bump is required to satisfy a dependency that requires that node version. In addition, Parse Dashboard is not officially compatible with Node 16 yet, as tests don't pass. * remove parse server dev dependency * minor fixes * just trying node 16 after removing parse server * enabling node 16 * enabling node 16 * disabling node 16 as it still doesn't pass * updating node engine requirement
1 parent a637256 commit 15bd67e

File tree

6 files changed

+75
-2811
lines changed

6 files changed

+75
-2811
lines changed

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ jobs:
131131
- name: Node 14
132132
NODE_VERSION: 14.17.6
133133
# Enable the following lines when Parse Dashboard reached Node 16 compatibility
134-
#- name: Node 16
135-
# NODE_VERSION: 16.9.0
134+
# - name: Node 16
135+
# NODE_VERSION: 16.9.0
136136
fail-fast: false
137137
name: ${{ matrix.name }}
138138
timeout-minutes: 15

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
- Fixed UI for a field containing an array of pointers (Prerna Mehra) [#1776](https://github.com/parse-community/parse-dashboard/pull/1776)
2020
- Fixed bug when editing or copying a field containing an array of pointers [#1770](https://github.com/parse-community/parse-dashboard/issues/1770) (Prerna Mehra) [#1771](https://github.com/parse-community/parse-dashboard/pull/1771)
2121
- Modernize CI (Manuel Trezza) [#1789](https://github.com/parse-community/parse-dashboard/pull/1789)
22+
- ci: Remove parse-server dev dependency (Manuel Trezza) [#1796](https://github.com/parse-community/parse-dashboard/pull/1796)
2223

2324
# 2.2.0
2425
[Full Changelog](https://github.com/parse-community/parse-dashboard/compare/2.1.0...2.2.0)

ci/nodeEngineCheck.js

+4-7
Original file line numberDiff line numberDiff line change
@@ -175,16 +175,13 @@ async function check() {
175175
for (const higherVersion of higherVersions) {
176176

177177
// Get package name
178-
const package = higherVersion.file.split('node_modules/').pop().replace('/package.json', '');
179-
console.log(`- ${package} requires at least node ${higherVersion.nodeMinVersion} (${higherVersion.nodeVersion})`);
178+
const _package = higherVersion.file.split('node_modules/').pop().replace('/package.json', '');
179+
console.log(`- ${_package} requires at least node ${higherVersion.nodeMinVersion} (${higherVersion.nodeVersion})`);
180180
}
181-
console.log('');
182-
core.setFailed(`❌ Upgrade the node engine version in package.json to at least '${highestVersion}' to satisfy the dependencies.`);
183-
console.log('');
181+
core.setFailed(`\n❌ Upgrade the node engine version in package.json to at least '${highestVersion}' to satisfy the dependencies.\n`);
184182
return;
185183
}
186-
187-
console.log(`✅ All dependencies satisfy the node version requirement of the parent package (${parentVersion.nodeVersion}).`);
184+
console.log(`\n✅ All dependencies satisfy the node version requirement of the parent package (${parentVersion.nodeVersion}).\n`);
188185
}
189186

190187
check();

0 commit comments

Comments
 (0)