fix: Pagination does not reset to page 1 when clicking on class or filter

[mtrezza]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Issue Description

Pagination does not reset to page 1 when clicking on class or filter

Approach

Reset to page 1 on:

• click on class
• delete filter
• click on filter

Summary by CodeRabbit

• New Features

  • Clicking on a category now triggers an additional action, enhancing interactivity in the category list.

• Bug Fixes

  • Pagination is automatically reset to the first page whenever a filter or category is selected or removed, ensuring users always start from the beginning after changing filters or categories.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce a new classClicked callback to the CategoryList component, which is triggered when a category link is clicked. In the Browser component, the classClicked, filterClicked, and removeFilter callbacks are updated to reset the pagination offset (skip state) to zero, ensuring pagination starts from the first page upon class or filter changes.

Changes

File(s)	Change Summary
src/components/CategoryList/CategoryList.react.js	Added onClick handler to category links to call this.props.classClicked() when a category is selected.
src/dashboard/Data/Browser/Browser.react.js	Updated sidebar callbacks to reset pagination (skip state) to zero on class/filter changes; added classClicked callback.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CategoryList
    participant Browser

    User->>CategoryList: Clicks category link
    CategoryList->>Browser: Calls classClicked()
    Browser->>Browser: setState({ skip: 0 })
    Browser->>Browser: Navigate to new class (unchanged)

Loading

Possibly related PRs

• fix: Clicking on pointer in data browser when using pagination does not reset to first page #2767: Both PRs modify the Browser component to reset the pagination offset (skip) to zero when navigating via user interactions related to class or pointer clicks, ensuring pagination resets correctly on filter or class changes.

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 752841a and 51f971e.

📒 Files selected for processing (2)

• src/components/CategoryList/CategoryList.react.js (1 hunks)
• src/dashboard/Data/Browser/Browser.react.js (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/dashboard/Data/Browser/Browser.react.js (1)

src/lib/generatePath.js (1)

• generatePath (3-8)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Docker linux/amd64

🔇 Additional comments (2)

src/components/CategoryList/CategoryList.react.js (1)

125-125: Good addition of the click handler for pagination reset

This change adds an onClick event handler to the category link that calls this.props.classClicked() when clicked. This enables the Browser component to reset pagination when a class is selected, which fixes the issue described in the PR.

src/dashboard/Data/Browser/Browser.react.js (1)

1881-1907: Excellent implementation of pagination reset across all navigation actions

The changes properly implement pagination reset by setting skip: 0 when:

1. Clicking on a class (new classClicked callback)
2. Clicking on a filter (filterClicked callback)
3. Removing a filter (removeFilter callback)

This ensures that whenever the user changes the data context by selecting a different class or modifying filters, the pagination always starts from the first page, which fixes the issue mentioned in the PR.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[parseplatformorg]

🎉 This change has been released in version 7.2.0-alpha.2

[parseplatformorg]

🎉 This change has been released in version 7.2.0