From c1941611d42ebcfccdcef94e33ae44ade108be8f Mon Sep 17 00:00:00 2001 From: Wassime BOUIMADAGHENE Date: Sat, 6 Apr 2019 22:27:49 +0200 Subject: [PATCH 1/2] Correct inappropriate error message when no target audience is selected --- CHANGELOG.md | 2 +- src/dashboard/Push/PushNew.react.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a181c008d1..28a6b33301 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ ## Parse Dashboard Changelog -* _Contributing to this repo? Add info about your change here to be included in next release_ +* Fix: Correct inappropriate error message when no target audience is selected. ### master [Full Changelog](https://github.com/parse-community/parse-dashboard/compare/1.3.0...master) diff --git a/src/dashboard/Push/PushNew.react.js b/src/dashboard/Push/PushNew.react.js index 3a9072f626..0f9b3e6119 100644 --- a/src/dashboard/Push/PushNew.react.js +++ b/src/dashboard/Push/PushNew.react.js @@ -729,7 +729,7 @@ class PushNew extends DashboardView { let invalidInputMessages = []; if (!this.state.audienceId) { - emptyInputMessages.push('you need select an audience'); + emptyInputMessages.push('target audience'); } // when number audience size is 0 From e0cc7e047829dc70c11f9aa8f4d8df59d89f68aa Mon Sep 17 00:00:00 2001 From: Tom Fox Date: Sun, 7 Apr 2019 00:06:11 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 28a6b33301..baeb0ed749 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,9 +1,11 @@ ## Parse Dashboard Changelog -* Fix: Correct inappropriate error message when no target audience is selected. ### master [Full Changelog](https://github.com/parse-community/parse-dashboard/compare/1.3.0...master) +* _Contributing to this repo? Add info about your change here to be included in next release_ +* Fix: Correct inappropriate error message when no target audience is selected (#1052), thanks to [Bouimadaghene](https://github.com/starbassma) + ### 1.3.0 [Full Changelog](https://github.com/parse-community/parse-dashboard/compare/1.2.0...1.3.0)