Skip to content

Commit 090521f

Browse files
committed
💣 removes exposed files adapter
- Should fix problems with GCS - Throws error that shows the right repo
1 parent f99b558 commit 090521f

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,7 @@
3333
"mongodb": "~2.1.0",
3434
"multer": "^1.1.0",
3535
"parse": "^1.8.0",
36-
"parse-server-fs-adapter": "^1.0.0",
37-
"parse-server-gcs-adapter": "^1.0.0",
3836
"parse-server-push-adapter": "^1.0.0",
39-
"parse-server-s3-adapter": "^1.0.0",
40-
"parse-server-simple-mailgun-adapter": "^1.0.0",
4137
"redis": "^2.5.0-1",
4238
"request": "^2.65.0",
4339
"tv4": "^1.2.7",
@@ -61,7 +57,11 @@
6157
"gaze": "^0.5.2",
6258
"jasmine": "^2.3.2",
6359
"mongodb-runner": "3.1.15",
64-
"nodemon": "^1.8.1"
60+
"nodemon": "^1.8.1",
61+
"parse-server-fs-adapter": "^1.0.0",
62+
"parse-server-gcs-adapter": "^1.0.0",
63+
"parse-server-s3-adapter": "^1.0.0",
64+
"parse-server-simple-mailgun-adapter": "^1.0.0"
6565
},
6666
"scripts": {
6767
"dev": "npm run build && node bin/dev",

spec/index.spec.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -241,10 +241,10 @@ describe('server', () => {
241241
done();
242242
});
243243

244-
it('exposes all the "core" adapters', done => {
245-
expect(ParseServer.S3Adapter).toThrow();
246-
expect(ParseServer.GCSAdapter).toThrow('GCSAdapter requires an projectId');
247-
expect(ParseServer.FileSystemAdapter).toThrow();
244+
it('core adapters are not exposed anymore', done => {
245+
expect(ParseServer.S3Adapter).toThrow('S3Adapter is not provided by parse-server anymore; please install parse-server-s3-adapter');
246+
expect(ParseServer.GCSAdapter).toThrow('GCSAdapter is not provided by parse-server anymore; please install parse-server-gcs-adapter');
247+
expect(ParseServer.FileSystemAdapter).toThrow('FileSystemAdapter is not provided by parse-server anymore; please install parse-server-fs-adapter');
248248
done();
249249
});
250250

src/index.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
import winston from 'winston';
22
import ParseServer from './ParseServer';
3-
import GCSAdapter from 'parse-server-gcs-adapter';
4-
import S3Adapter from 'parse-server-s3-adapter';
5-
import FileSystemAdapter from 'parse-server-fs-adapter';
63

74
if (process.env.VERBOSE || process.env.VERBOSE_PARSE_SERVER) {
85
winston.level = 'silly';
@@ -20,5 +17,14 @@ let _ParseServer = function(options) {
2017
// Mount the create liveQueryServer
2118
_ParseServer.createLiveQueryServer = ParseServer.createLiveQueryServer;
2219

20+
function useExternal(name, moduleName) {
21+
return function() {
22+
throw `${name} is not provided by parse-server anymore; please install ${moduleName}`;
23+
}
24+
}
25+
let S3Adapter = useExternal('S3Adapter', 'parse-server-s3-adapter');
26+
let GCSAdapter = useExternal('GCSAdapter', 'parse-server-gcs-adapter')
27+
let FileSystemAdapter = useExternal('FileSystemAdapter', 'parse-server-fs-adapter')
28+
2329
export default ParseServer;
2430
export { S3Adapter, GCSAdapter, FileSystemAdapter, _ParseServer as ParseServer };

0 commit comments

Comments
 (0)