wordsmithery and grammar

Author: acinader

src/RestWrite.js

@@ -620,16 +620,23 @@ RestWrite.prototype._validateUserName = function() {
     return Promise.resolve();
   }
   /*
-    Username's should be unique when compared case insensitively
+    Usernames should be unique when compared case insensitively
 
-    User's should be able to make case sensitive usernames and
+    Users should be able to make case sensitive usernames and
     login using the case they entered.  I.e. 'Snoopy' should preclude
     'snoopy' as a valid username.
 
-    Users that use authentication adapters should enforce unique ids
-    through a unique index on username.  Failure to enforce through an index
-    allows for a potential collision for adapter users (a low probability outcome)
-    but more importantly will have poor performance on this validation.
+    However, authentication adapters require a looser check that takes
+    case into consideration when determining uniqueness.
+
+    The username field should have a unique index on the database as
+    Failure to enforce through an index allows for a potential collision
+    for adapter users (a low probability outcome) but more importantly
+    will have poor performance on this validation.
+
+    The check below has the potential to not allow a valid
+    username for an adapter other than anonymous, this should
+    be fixed.
   */
   return this.config.database
     .find(
@@ -655,9 +662,9 @@ RestWrite.prototype._validateUserName = function() {
 };
 
 /*
-  As with username's, parse should not allow case insensitive collisions of email
-  unlike with usernames (which can have case insensitive collisions) emails should
-  never have a case insensitive collision.
+  As with usernames, Parse should not allow case insensitive collisions of email.
+  unlike with usernames (which can have case insensitive collisions in the case of
+  auth adapters), emails should never have a case insensitive collision.
 
   This behavior can be enforced through a properly configured index see:
   https://docs.mongodb.com/manual/core/index-case-insensitive/#create-a-case-insensitive-index
@@ -685,7 +692,8 @@ RestWrite.prototype._validateEmail = function() {
       this.className,
       {
         email: { $regex: `^${this.data.email}$`, $options: 'i' },
-        objectId: { $ne: this.objectId() } },
+        objectId: { $ne: this.objectId() },
+      },
       { limit: 1 },
       {},
       this.validSchemaController