Skip to content

Cannot change password when maxPasswordHistory is 1 #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akiowata opened this issue Jul 30, 2018 · 4 comments
Closed

Cannot change password when maxPasswordHistory is 1 #4918

akiowata opened this issue Jul 30, 2018 · 4 comments

Comments

@akiowata
Copy link

Issue Description

When I set passwordPolicy of maxPasswordHistory: 1,
reset password doesn't work at last step (after inputting a new password).

I found the process below has infinite loop.

while (oldPasswords.length > this.config.passwordPolicy.maxPasswordHistory - 2) {

Steps to reproduce

  1. Set passwordPolicy of maxPasswordHistory as 1.
  2. Try resetting password.

Expected Results

That it works.

Actual Outcome

No responce.

@flovilmart
Copy link
Contributor

@akiowata can you provide a workaround? and a PR? That should be an accessible one for a new contributor.

@paulovitin
Copy link
Contributor

@Tolsee
Copy link
Contributor

Tolsee commented Nov 25, 2018

@paulovitin Is the test enough? It is already passing, right?

@dplewis
Copy link
Member

dplewis commented Apr 11, 2019

Closing via #5191

@dplewis dplewis closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants