-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Rate limit feature is incompatible with Node 14 #8577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening this issue!
|
That's the unfortunate effect of flaky tests. They are so frequent (although much has improved in the past year) that a failing test easily gets mistaken for being flaky. I think as a new rule we'll re-run the CI until all tests pass before merging a PR. I think that can be set as required in the repo setting so that also reviewers and maintainers cannot skip that. Maybe we can find a Node compat check for the CI that explicitly check for commands that require a higher Node version than the min package version. |
🎉 This change has been released in version 6.1.0-alpha.13 |
🎉 This change has been released in version 6.3.0-beta.1 |
🎉 This change has been released in version 6.3.0-alpha.1 |
🎉 This change has been released in version 6.3.0 |
New Issue Checklist
Issue Description
When updating #8558, I assumed the Node 14 failure was flaky. It was not.
The code uses String.replaceAll, which is available in Node 15+
Steps to reproduce
Actual Outcome
Expected Outcome
Environment
Server
FILL_THIS_OUT
FILL_THIS_OUT
FILL_THIS_OUT
Database
FILL_THIS_OUT
FILL_THIS_OUT
FILL_THIS_OUT
Client
FILL_THIS_OUT
FILL_THIS_OUT
Logs
The text was updated successfully, but these errors were encountered: