Skip to content

Rate limit feature is incompatible with Node 14 #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
dblythy opened this issue May 25, 2023 · 6 comments · Fixed by #8578
Closed
4 tasks done

Rate limit feature is incompatible with Node 14 #8577

dblythy opened this issue May 25, 2023 · 6 comments · Fixed by #8578
Labels
block:beta Needs to be resolved before next release on beta branch; remove label afterwards state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@dblythy
Copy link
Member

dblythy commented May 25, 2023

New Issue Checklist

Issue Description

When updating #8558, I assumed the Node 14 failure was flaky. It was not.

The code uses String.replaceAll, which is available in Node 15+

Steps to reproduce

Actual Outcome

Expected Outcome

Environment

Server

  • Parse Server version: FILL_THIS_OUT
  • Operating system: FILL_THIS_OUT
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): FILL_THIS_OUT

Database

  • System (MongoDB or Postgres): FILL_THIS_OUT
  • Database version: FILL_THIS_OUT
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): FILL_THIS_OUT

Client

  • SDK (iOS, Android, JavaScript, PHP, Unity, etc): FILL_THIS_OUT
  • SDK version: FILL_THIS_OUT

Logs

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 25, 2023

Thanks for opening this issue!

  • ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your issue will be closed. If a field does not apply to the issue, fill in n/a.

@mtrezza
Copy link
Member

mtrezza commented May 25, 2023

That's the unfortunate effect of flaky tests. They are so frequent (although much has improved in the past year) that a failing test easily gets mistaken for being flaky. I think as a new rule we'll re-run the CI until all tests pass before merging a PR. I think that can be set as required in the repo setting so that also reviewers and maintainers cannot skip that.

Maybe we can find a Node compat check for the CI that explicitly check for commands that require a higher Node version than the min package version.

@mtrezza mtrezza added block:beta Needs to be resolved before next release on beta branch; remove label afterwards type:bug Impaired feature or lacking behavior that is likely assumed labels May 25, 2023
@mtrezza mtrezza changed the title rateLimit fails on Node 14 Rate limit feature is incompatible with Node 14 May 25, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.13

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 25, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block:beta Needs to be resolved before next release on beta branch; remove label afterwards state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants