diff --git a/spec/ParseAPI.spec.js b/spec/ParseAPI.spec.js index 67e414b752..52c17fbfed 100644 --- a/spec/ParseAPI.spec.js +++ b/spec/ParseAPI.spec.js @@ -587,7 +587,7 @@ describe('miscellaneous', function() { done(); }); }); - + it('test cloud function query parameters', (done) => { Parse.Cloud.define('echoParams', (req, res) => { res.success(req.params); @@ -621,8 +621,8 @@ describe('miscellaneous', function() { // Register a function with validation Parse.Cloud.define('functionWithParameterValidation', (req, res) => { res.success('works'); - }, (params) => { - return params.success === 100; + }, (request) => { + return request.params.success === 100; }); Parse.Cloud.run('functionWithParameterValidation', {"success":100}).then((s) => { @@ -638,8 +638,8 @@ describe('miscellaneous', function() { // Register a function with validation Parse.Cloud.define('functionWithParameterValidationFailure', (req, res) => { res.success('noway'); - }, (params) => { - return params.success === 100; + }, (request) => { + return request.params.success === 100; }); Parse.Cloud.run('functionWithParameterValidationFailure', {"success":500}).then((s) => { @@ -721,4 +721,15 @@ describe('miscellaneous', function() { }); }); + it('fails on invalid function', done => { + Parse.Cloud.run('somethingThatDoesDefinitelyNotExist').then((s) => { + fail('This should have never suceeded'); + done(); + }, (e) => { + expect(e.code).toEqual(Parse.Error.SCRIPT_FAILED); + expect(e.message).toEqual('Invalid function.'); + done(); + }); + }); + }); diff --git a/src/functions.js b/src/functions.js index c787a814f4..8e88aa0358 100644 --- a/src/functions.js +++ b/src/functions.js @@ -10,10 +10,15 @@ var router = new PromiseRouter(); function handleCloudFunction(req) { if (Parse.Cloud.Functions[req.params.functionName]) { - const params = Object.assign({}, req.body, req.query); - + var request = { + params: Object.assign({}, req.body, req.query), + master: req.auth && req.auth.isMaster, + user: req.auth && req.auth.user, + installationId: req.info.installationId + }; + if (Parse.Cloud.Validators[req.params.functionName]) { - var result = Parse.Cloud.Validators[req.params.functionName](params); + var result = Parse.Cloud.Validators[req.params.functionName](request); if (!result) { throw new Parse.Error(Parse.Error.SCRIPT_FAILED, 'Validation failed.'); } @@ -21,12 +26,6 @@ function handleCloudFunction(req) { return new Promise(function (resolve, reject) { var response = createResponseObject(resolve, reject); - var request = { - params: params, - master: req.auth && req.auth.isMaster, - user: req.auth && req.auth.user, - installationId: req.info.installationId - }; Parse.Cloud.Functions[req.params.functionName](request, response); }); } else {