From aea1399d30fadcc845adb6abca059e9b5b199a09 Mon Sep 17 00:00:00 2001 From: Darren Black Date: Sat, 26 Jan 2019 22:13:13 +0100 Subject: [PATCH 1/2] Hides token contents in logStartupOptions if they arrive as a buffer --- src/cli/utils/runner.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cli/utils/runner.js b/src/cli/utils/runner.js index 1f1a7c1b56..c9090b928d 100644 --- a/src/cli/utils/runner.js +++ b/src/cli/utils/runner.js @@ -6,6 +6,11 @@ function logStartupOptions(options) { if (key == 'masterKey') { value = '***REDACTED***'; } + if (key == 'push') { + if (Buffer.isBuffer(value.ios.token.key)) { + value.ios.token.key = '***REDACTED***'; + } + } if (typeof value === 'object') { try { value = JSON.stringify(value); From a223bfc31828ef1abc97e9e33e5110f48bfcd2ec Mon Sep 17 00:00:00 2001 From: Darren Black Date: Sun, 27 Jan 2019 19:44:16 +0100 Subject: [PATCH 2/2] Hides all push details in logStartupOptions unless we're in verbose mode --- src/cli/utils/runner.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/cli/utils/runner.js b/src/cli/utils/runner.js index c9090b928d..d3510042c8 100644 --- a/src/cli/utils/runner.js +++ b/src/cli/utils/runner.js @@ -6,10 +6,8 @@ function logStartupOptions(options) { if (key == 'masterKey') { value = '***REDACTED***'; } - if (key == 'push') { - if (Buffer.isBuffer(value.ios.token.key)) { - value.ios.token.key = '***REDACTED***'; - } + if (key == 'push' && process.env.VERBOSE != true) { + value = '***REDACTED***'; } if (typeof value === 'object') { try {