Skip to content

Commit d97d915

Browse files
Ganqxpm215
authored andcommitted
exynos4210_mct: Use ptimer_free() in the finalize function to avoid memleaks
When running device-introspect-test, a memory leak occurred in the exynos4210_mct_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 96 byte(s) in 1 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db78 in ptimer_init /qemu/hw/core/ptimer.c:432 #3 0xaaabf56b01a0 in exynos4210_mct_init /qemu/hw/timer/exynos4210_mct.c:1505 #4 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 #5 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 #6 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds.c:153 #7 0xaaabf653d8ec in qmp_marshal_device_list_properties /qemu/qapi/qapi-commands-qdev.c:59 #8 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110 #9 0xaaabf6552708 in aio_bh_call /qemu/util/async.c:136 #10 0xaaabf6552708 in aio_bh_poll /qemu/util/async.c:164 #11 0xaaabf655f19c in aio_dispatch /qemu/util/aio-posix.c:381 #12 0xaaabf65523f4 in aio_ctx_dispatch /qemu/util/async.c:306 Reported-by: Euler Robot <[email protected]> Signed-off-by: Gan Qixin <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
1 parent a4bc033 commit d97d915

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

hw/timer/exynos4210_mct.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1530,6 +1530,19 @@ static void exynos4210_mct_init(Object *obj)
15301530
sysbus_init_mmio(dev, &s->iomem);
15311531
}
15321532

1533+
static void exynos4210_mct_finalize(Object *obj)
1534+
{
1535+
int i;
1536+
Exynos4210MCTState *s = EXYNOS4210_MCT(obj);
1537+
1538+
ptimer_free(s->g_timer.ptimer_frc);
1539+
1540+
for (i = 0; i < 2; i++) {
1541+
ptimer_free(s->l_timer[i].tick_timer.ptimer_tick);
1542+
ptimer_free(s->l_timer[i].ptimer_frc);
1543+
}
1544+
}
1545+
15331546
static void exynos4210_mct_class_init(ObjectClass *klass, void *data)
15341547
{
15351548
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -1543,6 +1556,7 @@ static const TypeInfo exynos4210_mct_info = {
15431556
.parent = TYPE_SYS_BUS_DEVICE,
15441557
.instance_size = sizeof(Exynos4210MCTState),
15451558
.instance_init = exynos4210_mct_init,
1559+
.instance_finalize = exynos4210_mct_finalize,
15461560
.class_init = exynos4210_mct_class_init,
15471561
};
15481562

0 commit comments

Comments
 (0)