Skip to content

Investigate resolving differences between CodeMessage and CodeModal #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert opened this issue Feb 3, 2025 · 1 comment
Labels
PF6 Applies to only the PF6 version

Comments

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Feb 3, 2025

There are some unresolved areas of difference between Figma and the codebase that Kayla would love to have resolved. One example is the code message and code editor modal. In Figma, these are 1 single component. Kayla would expect these components to be identical in look and feel. In the codebase, we are using two different PatternFly components, one of which is largely based around a third-party Monaco editor. This is not currently themed using PatternFly, which makes it difficult to change to exactly match design parameters at present. We would also need to explore what customizations are possible to get more of a match to the design using the default PatternFly components.

These are some options provided by Kayla:
Image

Note that the existing code editor/code message do not exhibit the "old" behavior in dark mode at present.

Kayla and team want to use CodeBlock for everything that doesn't require editing. CodeEditor may make more sense where editing is important.

See also #149 for some of the earlier problems.

@andrew-ronaldson
Copy link

Added a react issue to enable this patternfly/patternfly-react#11506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PF6 Applies to only the PF6 version
Projects
Status: Backlog
Development

No branches or pull requests

2 participants