Skip to content

Commit d7cb7b1

Browse files
author
Eric Olkowski
committed
Updated tests per Austin feedback
1 parent a658ca3 commit d7cb7b1

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

packages/react-core/src/components/HelperText/__tests__/HelperTextItem.test.tsx

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ test('Renders custom className', () => {
3333
test('Does not render screen reader text by default', () => {
3434
render(<HelperTextItem>help test text 1</HelperTextItem>);
3535

36-
expect(screen.queryByText('help test text 1')?.querySelector('.pf-v5-screen-reader')).not.toBeInTheDocument();
36+
expect(screen.queryByText('status')).not.toBeInTheDocument();
3737
});
3838

3939
Object.values(['indeterminate', 'warning', 'success', 'error']).forEach((variant) => {
@@ -52,10 +52,21 @@ Object.values(['indeterminate', 'warning', 'success', 'error']).forEach((variant
5252
text
5353
</HelperTextItem>
5454
);
55-
expect(screen.getByText('text').querySelector('span')).toHaveTextContent(`: ${variant} status;`);
55+
expect(screen.getByText(`: ${variant} status;`)).toBeInTheDocument();
5656
});
5757
});
5858

59+
test('Renders custom screen reader text', () => {
60+
render(
61+
<HelperTextItem variant="error" screenReaderText="danger">
62+
help test text 1
63+
</HelperTextItem>
64+
);
65+
66+
expect(screen.queryByText(': error status;')).not.toBeInTheDocument();
67+
expect(screen.getByText(': danger;')).toBeInTheDocument();
68+
});
69+
5970
test('Renders id when id is passed', () => {
6071
render(<HelperTextItem id="text-item">help test text 1</HelperTextItem>);
6172
expect(screen.getByText('help test text 1').parentElement).toHaveAttribute('id', 'text-item');

0 commit comments

Comments
 (0)