Skip to content

Form - support for field group animation #11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcoker opened this issue May 21, 2025 · 0 comments · May be fixed by #11843
Open

Form - support for field group animation #11840

mcoker opened this issue May 21, 2025 · 0 comments · May be fixed by #11843
Assignees
Labels
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented May 21, 2025

Core issue patternfly/patternfly#7544

I believe all that's needed is

  • Adds .pf-m-expandable to the __field-group element that serves as the opt-in for this animation
  • __field-group-body is currently the "expanded content" and is conditionally rendered. If a user has opted in to the animation, we should always render that element and add inert when the field group is not expanded
  • In a future breaking change release, we'll want to
    • Add .pf-m-expandable to all expandable field groups
    • Always render __field-group-body in an expandable field group
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 21, 2025
@thatblindgeye thatblindgeye self-assigned this May 22, 2025
@thatblindgeye thatblindgeye moved this from Needs triage to PR Review in PatternFly Issues May 22, 2025
@thatblindgeye thatblindgeye added this to the 2025.Q2 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: PR Review
Development

Successfully merging a pull request may close this issue.

2 participants