Skip to content

Bug - SearchInput - result implementation lacks context #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thatblindgeye opened this issue Jan 9, 2025 · 1 comment · Fixed by #11844
Closed

Bug - SearchInput - result implementation lacks context #11398

thatblindgeye opened this issue Jan 9, 2025 · 1 comment · Fixed by #11844
Assignees

Comments

@thatblindgeye
Copy link
Contributor

Describe the problem
When the resultCount prop is used, the rendered badge lacks context for what the number/string is for when navigated via AT. The match with result count example displays "3" in a badge, but when announced via VoiceOver it may not be clear what "3" means. A similar issue arrises in the "Match with navigable options" example.

Ideally either a React node could be passed to the resultCount prop, so that screen reader text could be suffixed onto the result amount (e.g. <span>3 <span className="pf-v6-u-screen-reader">results</span></span>, or another prop is introduced to customize the word/phrase that comes after the resultCount that we render inside that screen reader class ourselves.

Note that once this is resolved in React, we should open a followup in Core to update any TextInputGroup > search input group examples to match markup.

How do you reproduce the problem?
Go to either of the above example and navigate/interact with VoiceOver. Notice after typing in the input and navigating to the result count, it isn't totally clear what "three" or "one slash three" means.

Expected behavior
More context is provided by the result count.

Is this issue blocking you?
List the workaround if there is one.

Screenshots
If applicable, add screenshots to help explain the issue.

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

What is your product and what release date are you targeting?

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 9, 2025
@thatblindgeye thatblindgeye moved this from Needs triage to Backlog in PatternFly Issues Jan 23, 2025
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Mar 11, 2025
@nicolethoen nicolethoen self-assigned this May 2, 2025
@nicolethoen nicolethoen assigned parthivrh and unassigned nicolethoen May 27, 2025
@nicolethoen nicolethoen moved this from Backlog to In Progress in PatternFly Issues May 27, 2025
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues May 27, 2025
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants