Button - add favorite variant #11809
Comments
|
I think just the plain button and plain no padding are a good start. Favouriting shouldn't be in any of the pills |
|
As part of this we should also update the FavoriteCell component in the react-table package |
|
@thatblindgeye I would like to work on this, could assign this to me. Thank You |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Main core PR - patternfly/patternfly#7379
Animate between filled/unfilled icon PR - patternfly/patternfly#7492
TL;DR:
.pf-m-favoriteas the class that always needs to be on a favorite button.pf-m-favoritedthat toggles a.pf-m-favoritebutton between favorited/not-favoritedbutton__iconcontainer, adds 2 new elements that both need to be rendered at the same time. CSS hides/shows the correct icon.button__icon-favorite- this will hold<OutlinedStarIcon>, for the non-favorited statebutton__icon-favorited- this will hold<StarIcon>, for the favorited stateToggling
.pf-m-favoritedsets the appropriate colors and swaps the visibility of the star and outlined star icons@andrew-ronaldson @srambach are there any limitations to which kind of button this should apply to? Technically it could apply to any button, though there may be color contrast issues if the button doesn't have a transparent background - so all buttons except primary, warning, and danger. Or is this only intended to be used with plain buttons?
The text was updated successfully, but these errors were encountered: