From 7702c422e4449ea429c8284e4aa83c44e91fa25a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Pet=C5=99=C3=ADk?= Date: Fri, 14 Oct 2022 14:01:12 +0200 Subject: [PATCH 1/3] chore(Tooltip) remove deprecated props --- .../src/components/Tooltip/Tooltip.tsx | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/packages/react-core/src/components/Tooltip/Tooltip.tsx b/packages/react-core/src/components/Tooltip/Tooltip.tsx index 041f7713064..bd202579146 100644 --- a/packages/react-core/src/components/Tooltip/Tooltip.tsx +++ b/packages/react-core/src/components/Tooltip/Tooltip.tsx @@ -8,7 +8,6 @@ import { KeyTypes } from '../../helpers/constants'; import tooltipMaxWidth from '@patternfly/react-tokens/dist/esm/c_tooltip_MaxWidth'; import { ReactElement } from 'react'; import { Popper, getOpacityTransition } from '../../helpers/Popper/Popper'; -import { Props as TippyProps } from '../../helpers/Popper/DeprecatedTippyTypes'; export enum TooltipPosition { auto = 'auto', @@ -132,12 +131,6 @@ export interface TooltipProps extends Omit, 'con id?: string; /** CSS fade transition animation duration */ animationDuration?: number; - /** @deprecated - no longer used. if you want to constrain the popper to a specific element use the appendTo prop instead */ - boundary?: 'scrollParent' | 'window' | 'viewport' | HTMLElement; - /** @deprecated - no longer used */ - isAppLauncher?: boolean; - /** @deprecated - no longer used */ - tippyProps?: Partial; /** @beta Opt-in for updated popper that does not use findDOMNode. */ removeFindDomNode?: boolean; } @@ -167,21 +160,9 @@ export const Tooltip: React.FunctionComponent = ({ animationDuration = 300, reference, 'aria-live': ariaLive = reference ? 'polite' : 'off', - boundary, - isAppLauncher, - tippyProps, removeFindDomNode = false, ...rest }: TooltipProps) => { - if (process.env.NODE_ENV !== 'production') { - boundary !== undefined && - console.warn( - 'The Tooltip boundary prop has been deprecated. If you want to constrain the popper to a specific element use the appendTo prop instead.' - ); - isAppLauncher !== undefined && - console.warn('The Tooltip isAppLauncher prop has been deprecated and is no longer used.'); - tippyProps !== undefined && console.warn('The Tooltip tippyProps prop has been deprecated and is no longer used.'); - } // could make this a prop in the future (true | false | 'toggle') const hideOnClick = true; const triggerOnMouseenter = trigger.includes('mouseenter'); From 0cd4fc6a4b4a23370222624138b53b19ae611861 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Pet=C5=99=C3=ADk?= Date: Fri, 14 Oct 2022 14:18:30 +0200 Subject: [PATCH 2/3] fix demo --- .../src/components/demos/TooltipDemo/TooltipDemo.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx index fe210bec6f4..e6f8a57f212 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx @@ -21,7 +21,7 @@ export class TooltipDemo extends Component { return (
{this.myTooltipProps.children} - +
From a5fee55abbe34d32dba57861133ce061473e1e97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominik=20Pet=C5=99=C3=ADk?= Date: Thu, 20 Oct 2022 10:09:01 +0200 Subject: [PATCH 3/3] remove deprecated test from demo --- .../src/components/demos/TooltipDemo/TooltipDemo.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx index e6f8a57f212..fd96e2f1b0d 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx @@ -21,9 +21,6 @@ export class TooltipDemo extends Component { return (
{this.myTooltipProps.children} - - -