From 5235817c7f73d7f2d7d6fed3e9509257e689a95e Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Fri, 16 Dec 2022 14:11:25 -0500 Subject: [PATCH 1/2] feat(Tooltip): remove deprecated props --- packages/eslint-plugin-pf-codemods/index.js | 1 + .../lib/rules/v5/tooltip-remove-props.js | 15 +++++++++ .../test/rules/v5/tooltip-remove-props.js | 32 +++++++++++++++++++ packages/pf-codemods/README.md | 18 +++++++++++ 4 files changed, 66 insertions(+) create mode 100644 packages/eslint-plugin-pf-codemods/lib/rules/v5/tooltip-remove-props.js create mode 100644 packages/eslint-plugin-pf-codemods/test/rules/v5/tooltip-remove-props.js diff --git a/packages/eslint-plugin-pf-codemods/index.js b/packages/eslint-plugin-pf-codemods/index.js index 939f27732..bfe062f8c 100644 --- a/packages/eslint-plugin-pf-codemods/index.js +++ b/packages/eslint-plugin-pf-codemods/index.js @@ -45,6 +45,7 @@ const rules = { "chart-remove-allowZoom": require('./lib/rules/v4/chartVoronoiContainer-remove-allowTooltip'), "react-icons-remove-icon": require('./lib/rules/v4/react-icons-remove-icon'), "toolbar-remove-visiblity": require('./lib/rules/v5/toolbar-remove-visiblity'), + "tooltip-remove-props": require('./lib/rules/v5/tooltip-remove-props'), "divider-remove-isVertical": require('./lib/rules/v5/divider-remove-isVertical'), }; diff --git a/packages/eslint-plugin-pf-codemods/lib/rules/v5/tooltip-remove-props.js b/packages/eslint-plugin-pf-codemods/lib/rules/v5/tooltip-remove-props.js new file mode 100644 index 000000000..45c439916 --- /dev/null +++ b/packages/eslint-plugin-pf-codemods/lib/rules/v5/tooltip-remove-props.js @@ -0,0 +1,15 @@ +const { renameProps } = require('../../helpers'); + +const renames = { + Tooltip: { + 'boundary': '', + 'isAppLauncher': '', + 'tippyProps': '' + } +}; + +// https://github.com/patternfly/patternfly-react/pull/8231 +module.exports = { + meta: { fixable: 'code' }, + create: renameProps(renames) +}; diff --git a/packages/eslint-plugin-pf-codemods/test/rules/v5/tooltip-remove-props.js b/packages/eslint-plugin-pf-codemods/test/rules/v5/tooltip-remove-props.js new file mode 100644 index 000000000..66211a8e1 --- /dev/null +++ b/packages/eslint-plugin-pf-codemods/test/rules/v5/tooltip-remove-props.js @@ -0,0 +1,32 @@ +const ruleTester = require('../../ruletester'); +const rule = require('../../../lib/rules/v5/tooltip-remove-props'); + +ruleTester.run("tooltip-remove-props", rule, { + valid: [ + { + code: `import { Tooltip } from '@patternfly/react-core'; `, + }, + { + // No @patternfly/react-core import + code: ``, + } + ], + invalid: [ + { + code: `import { Tooltip } from '@patternfly/react-core'; `, + output: `import { Tooltip } from '@patternfly/react-core'; `, + errors: [{ + message: `boundary prop for Tooltip has been removed`, + type: "JSXOpeningElement", + }, + { + message: `tippyProps prop for Tooltip has been removed`, + type: "JSXOpeningElement", + }, + { + message: `isAppLauncher prop for Tooltip has been removed`, + type: "JSXOpeningElement", + }] + } + ] +}); diff --git a/packages/pf-codemods/README.md b/packages/pf-codemods/README.md index 68c285f72..5624930d6 100644 --- a/packages/pf-codemods/README.md +++ b/packages/pf-codemods/README.md @@ -73,3 +73,21 @@ Out: ```jsx ``` + +### tooltip-remove-props [(#8231)](https://github.com/patternfly/patternfly-react/pull/8231) + +We've removed the `boundary`, `tippyProps`, and `isAppLauncher` properties from Tooltip. + +#### Examples + +In: + +```jsx + +``` + +Out: + +```jsx + +``` From 1802abfc1392de222951620dafbddf0eccef62e9 Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Tue, 3 Jan 2023 12:23:26 -0500 Subject: [PATCH 2/2] update readme output --- packages/pf-codemods/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/pf-codemods/README.md b/packages/pf-codemods/README.md index 5624930d6..69a598944 100644 --- a/packages/pf-codemods/README.md +++ b/packages/pf-codemods/README.md @@ -89,5 +89,5 @@ In: Out: ```jsx - + ```