Skip to content

Commit 6aa3349

Browse files
hashseedCommit Bot
authored and
Commit Bot
committed
Revert "[regexp] Include unicode/uvernum.h in parser"
This reverts commit 0db90bc. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/17335 You need to also check whether i18n is on, e.g. #ifdef V8_INTL_SUPPORT. Original change's description: > [regexp] Include unicode/uvernum.h in parser > > This patch explicitly includes unicode/uvernum.h in the regular > expression parser. > > It should be removed once we no longer need to check > `U_ICU_VERSION_MAJOR_NUM` during preprocessing, i.e. once Node.js > updates their ICU. This is an ongoing effort: > nodejs/node#16876 > > BUG=v8:4743 > > Change-Id: I3cd9447b481249a9035d9fb00745057da8809c58 > Reviewed-on: https://chromium-review.googlesource.com/758407 > Reviewed-by: Jakob Gruber <[email protected]> > Reviewed-by: Yang Guo <[email protected]> > Commit-Queue: Mathias Bynens <[email protected]> > Cr-Commit-Position: refs/heads/master@{#49253} [email protected],[email protected],[email protected],[email protected] Change-Id: I58d6b7a49b707c97153b8b0aec141248f5c669e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:4743 Reviewed-on: https://chromium-review.googlesource.com/759777 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#49255}
1 parent 07fc87a commit 6aa3349

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/regexp/regexp-parser.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@
1414
#include "src/regexp/jsregexp.h"
1515
#include "src/utils.h"
1616

17-
// TODO(mathias): Remove this when we no longer need to check
18-
// `U_ICU_VERSION_MAJOR_NUM`.
19-
#include "unicode/uvernum.h"
20-
2117
#ifdef V8_INTL_SUPPORT
2218
#include "unicode/uniset.h"
2319
#endif // V8_INTL_SUPPORT

0 commit comments

Comments
 (0)