add missing status "failed" and "expired" in enum Subscription.Status, thanks to @schaebo #59

removed subscriotion update by string

Author: schaebo

src/main/java/com/paymill/models/Subscription.java

@@ -493,7 +493,7 @@ public Subscription.Order byCreatedAt() {
 
   public enum Status {
 
-    ACTIVE("active"), INACTIVE("inactive");
+    ACTIVE("active"), INACTIVE("inactive"), FAILED("failed"), EXPIRED("expired");
 
     private String value;
 

src/main/java/com/paymill/services/SubscriptionService.java

@@ -697,36 +697,4 @@ private Subscription delete( Subscription subscription, boolean remove ) {
   public Subscription update( Subscription subscription ) {
     return RestfulUtils.update( SubscriptionService.PATH, subscription, Subscription.class, super.httpClient );
   }
-
-  /**
-   * Updates a subscription.Following fields will be updated:<br />
-   * <p>
-   * <ul>
-   * <li>interval (note, that nextCaptureAt will not change.)
-   * <li>currency
-   * <li>name
-   * <ul>
-   * <p>
-   * To update further properties of a subscription use following methods:<br />
-   * <p>
-   * <ul>
-   * <li>{@link SubscriptionService#cancel(Subscription)} to cancel
-   * <li>{@link SubscriptionService#changeAmount(Subscription, Integer)} to change the amount
-   * <li>{@link SubscriptionService#changeOfferChangeCaptureDateAndRefund(Subscription, Offer)} to change the offer.
-   * <li>{@link SubscriptionService#changeOfferKeepCaptureDateAndRefund(Subscription, Offer)} to change the offer.
-   * <li>{@link SubscriptionService#changeOfferKeepCaptureDateNoRefund(Subscription, Offer)} to change the offer.
-   * <li>{@link SubscriptionService#endTrial(Subscription)} to end the trial
-   * <li>{@link SubscriptionService#limitValidity(Subscription, com.paymill.models.Interval.Period} to change the validity.
-   * <li>{@link SubscriptionService#pause(Subscription)} to pause
-   * <li>{@link SubscriptionService#unlimitValidity(Subscription)} to change the validity.
-   * <li>{@link SubscriptionService#unpause(Subscription)} to unpause.
-   * <ul>
-   * <p>
-   * @param subscriptionId
-   *          Id of the {@link Subscription} to be updated.
-   * @return
-   */
-  public Subscription update( String subscriptionId ) {
-    return RestfulUtils.update( SubscriptionService.PATH, new Subscription( subscriptionId ), Subscription.class, super.httpClient );
-  }
 }