-
Notifications
You must be signed in to change notification settings - Fork 19
Any ideas to implement PHP 8.1 support? #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In fact, there are some: first the test suite should be upgraded using PHPUnit-polyfills package and migrated to Github Actions from Travis. This is similar to what was done in HTTP_Request2. I think we can safely drop support for PHP below 5.6 at this point, @golgote --- do you agree? After we have a test suite running on 8.1, fixing the package itself will probably be trivial.
Well, if you are willing to do the test suite migration then welcome aboard! |
hi @sad-spirit, any chance you'd be proceeding with implementation soon? |
Hello, @sad-spirit. I'm looking for the same solution with PHP 8.1 support! My code is ready to support 8.1 but due to the use of HTML_QuickForm2, I can't do it. Is there any chance of PHP 8.1 support coming soon? I wouldn't want to look for an alternative to HTML_QuickForm2 right now. But soon I'll have no choice. |
@thedotedge , @sychova-fh I'm currently working on upgrading the test suite, will probably finish in a few days. |
Please test the current HEAD with your code: I fixed all |
@sad-spirit Thank you so much for your work! I will test it ASAP |
Some warnings when running tests (not a blocker):
|
Version 2.3.0 released. Since test suite runs OK and psalm doesn't find any problems on reasonable level let's hope there are no more problems on PHP 8.1 |
Any ideas to implement PHP 8.1 support?
Do you have opportunity or time for it? I can help with implementation if you want.
The text was updated successfully, but these errors were encountered: