Skip to content

Commit 250f917

Browse files
committed
refactor(2020-02-12--empty_price_import_request.xml): split a migration with test data into separate tables.
Part of #1265 Related to #1257
1 parent 63ec471 commit 250f917

File tree

6 files changed

+38
-39
lines changed

6 files changed

+38
-39
lines changed

src/main/resources/liquibase/test-data.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<!-- Depends on: series_import_request_statuses, users -->
1111
<include file="test-data/series_import_requests.xml" relativeToChangelogFile="true" />
1212

13-
<!-- Depends on: series_import_requests -->
13+
<!-- Depends on: series_import_requests, categories -->
1414
<include file="test-data/series_import_parsed_data.xml" relativeToChangelogFile="true" />
1515

1616
<!-- Depends on: series_import_requests, transaction_participants -->

src/main/resources/liquibase/test-data/series_import_parsed_data.xml

+13
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,19 @@
55
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
66
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">
77

8+
<changeSet id="add-series-parsed-data-for-gh1256" author="php-coder" context="test-data">
9+
10+
<insert tableName="series_import_parsed_data">
11+
<column name="request_id" valueComputed="(SELECT id FROM series_import_requests WHERE url = 'http://example.com/issue/1256')" />
12+
<column name="category_id" valueComputed="(SELECT id FROM categories WHERE slug = 'prehistoric-animals')" />
13+
<column name="image_url" value="http://127.0.0.1:8080/image/1" />
14+
<column name="quantity" valueNumeric="3" />
15+
<column name="created_at" valueComputed="${NOW}" />
16+
<column name="updated_at" valueComputed="${NOW}" />
17+
</insert>
18+
19+
</changeSet>
20+
821
<changeSet id="add-series-parsed-data-for-gh1232" author="php-coder" context="test-data">
922

1023
<insert tableName="series_import_parsed_data">

src/main/resources/liquibase/test-data/series_import_requests.xml

+12
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,18 @@
55
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
66
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">
77

8+
<changeSet id="add-import-request-for-gh1256" author="php-coder" context="test-data">
9+
10+
<insert tableName="series_import_requests">
11+
<column name="url" value="http://example.com/issue/1256" />
12+
<column name="status_id" valueComputed="(SELECT id FROM series_import_request_statuses WHERE name = 'ParsingSucceeded')" />
13+
<column name="requested_at" valueComputed="${NOW}" />
14+
<column name="requested_by" valueComputed="(SELECT id FROM users WHERE role = 'ADMIN' ORDER by id LIMIT 1)" />
15+
<column name="updated_at" valueComputed="${NOW}" />
16+
</insert>
17+
18+
</changeSet>
19+
820
<changeSet id="add-import-request-for-gh1232" author="php-coder" context="test-data">
921

1022
<insert tableName="series_import_requests">

src/main/resources/liquibase/test-data/series_sales_import_parsed_data.xml

+12
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,18 @@
55
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
66
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">
77

8+
<changeSet id="add-series-sale-without-price" author="php-coder" context="test-data">
9+
10+
<insert tableName="series_sales_import_parsed_data">
11+
<column name="request_id" valueComputed="(SELECT id FROM series_import_requests WHERE url = 'http://example.com/issue/1256')" />
12+
<column name="seller_name" value="Issue 1256" />
13+
<column name="seller_url" value="http://example.com/issue/1256" />
14+
<column name="created_at" valueComputed="${NOW}" />
15+
<column name="updated_at" valueComputed="${NOW}" />
16+
</insert>
17+
18+
</changeSet>
19+
820
<changeSet id="add-series-sale-without-seller-info-but-with-price" author="php-coder" context="test-data">
921

1022
<insert tableName="series_sales_import_parsed_data">

src/main/resources/liquibase/version/0.4.2.xml

-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,5 @@
88
<include file="0.4.2/2019-11-17--drop_unique_series_from_collection.xml" relativeToChangelogFile="true" />
99
<include file="0.4.2/2019-11-27--add_collections_series_id.xml" relativeToChangelogFile="true" />
1010
<include file="0.4.2/2020-02-11--downloading_failed_import_requests.xml" relativeToChangelogFile="true" />
11-
<include file="0.4.2/2020-02-12--empty_price_import_request.xml" relativeToChangelogFile="true" />
1211

1312
</databaseChangeLog>

src/main/resources/liquibase/version/0.4.2/2020-02-12--empty_price_import_request.xml

-37
This file was deleted.

0 commit comments

Comments
 (0)