test(SeriesInfoExtractorServiceImpl.extractSellerGroup): add unit tests.

Fix #920

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/service/SeriesInfoExtractorServiceImpl.java

@@ -318,7 +318,6 @@ public Integer extractSeller(String name, String url) {
 		return null;
 	}
 
-	// @todo #857 SeriesInfoExtractorServiceImpl.extractSellerGroup(): add unit tests
 	public Integer extractSellerGroup(Integer id, String sellerUrl) {
 		// we need a group ony for a new seller (id == null)
 		if (id != null) {

src/test/groovy/ru/mystamps/web/service/SeriesInfoExtractorServiceImplTest.groovy

@@ -19,6 +19,7 @@ package ru.mystamps.web.service
 
 import static io.qala.datagen.RandomElements.from
 import static io.qala.datagen.RandomShortApi.nullOrBlank
+import static io.qala.datagen.RandomShortApi.positiveInteger
 import static io.qala.datagen.RandomValue.between
 
 import static ru.mystamps.web.service.SeriesInfoExtractorServiceImpl.MAX_SUPPORTED_RELEASE_YEAR
@@ -439,6 +440,39 @@ class SeriesInfoExtractorServiceImplTest extends Specification {
 			Random.id()    | _
 	}
 
+	//
+	// Tests for extractSellerGroup()
+	//
+	
+	def 'extractSellerGroup() should return null when id is not null'() {
+		expect:
+			service.extractSellerGroup(positiveInteger(), Random.url()) == null
+	}
+	
+	@Unroll
+	def 'extractSellerGroup() should return null for invalid url or unknown group (#sellerUrl)'(String sellerUrl) {
+		when:
+			Integer groupId = service.extractSellerGroup(null, sellerUrl)
+		then:
+			groupId == null
+		where:
+			sellerUrl             | _
+			nullOrBlank()         | _
+			'localhost'           | _
+			'https://example.org' | _
+	}
+	
+	def 'extractSellerGroup() should return seller group id'() {
+		given:
+			Integer expectedGroupId = positiveInteger()
+		when:
+			Integer groupId = service.extractSellerGroup(null, 'https://test.ru/about/me')
+		then:
+			1 * participantService.findGroupIdByName('test.ru') >> expectedGroupId
+		and:
+			groupId == expectedGroupId
+	}
+	
 	//
 	// Tests for extractSellerName()
 	//