Skip to content

Commit 49c56b2

Browse files
committed
refactor: eliminate useless usage of the GeneratedKeyHolder.
No functional changes.
1 parent f2d40d8 commit 49c56b2

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

src/main/java/ru/mystamps/web/feature/series/importing/JdbcSeriesImportDao.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -198,13 +198,7 @@ public void addParsedData(Integer requestId, AddSeriesParsedDataDbDto data) {
198198
params.put("perforated", data.getPerforated());
199199
params.put("michel_numbers", data.getMichelNumbers());
200200

201-
KeyHolder holder = new GeneratedKeyHolder();
202-
203-
int affected = jdbcTemplate.update(
204-
addParsedDataSql,
205-
new MapSqlParameterSource(params),
206-
holder
207-
);
201+
int affected = jdbcTemplate.update(addParsedDataSql, params);
208202

209203
Validate.validState(
210204
affected == 1,

src/main/java/ru/mystamps/web/feature/series/importing/sale/JdbcSeriesSalesImportDao.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,7 @@
2121
import org.apache.commons.lang3.Validate;
2222
import org.springframework.beans.factory.annotation.Value;
2323
import org.springframework.dao.EmptyResultDataAccessException;
24-
import org.springframework.jdbc.core.namedparam.MapSqlParameterSource;
2524
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
26-
import org.springframework.jdbc.support.GeneratedKeyHolder;
27-
import org.springframework.jdbc.support.KeyHolder;
2825

2926
import java.util.Collections;
3027
import java.util.HashMap;
@@ -54,13 +51,7 @@ public void addParsedData(Integer requestId, SeriesSalesParsedDataDbDto data) {
5451
params.put("created_at", data.getCreatedAt());
5552
params.put("updated_at", data.getUpdatedAt());
5653

57-
KeyHolder holder = new GeneratedKeyHolder();
58-
59-
int affected = jdbcTemplate.update(
60-
addParsedDataSql,
61-
new MapSqlParameterSource(params),
62-
holder
63-
);
54+
int affected = jdbcTemplate.update(addParsedDataSql, params);
6455

6556
Validate.validState(
6657
affected == 1,

0 commit comments

Comments
 (0)