Skip to content

Commit 862d2ec

Browse files
committed
ci: migrate checking by maven-enforcer-plugin from TravisCI to GitHub Actions
Part of #1154
1 parent 661444c commit 862d2ec

File tree

2 files changed

+20
-14
lines changed

2 files changed

+20
-14
lines changed

.github/workflows/static-analysis.yml

+18
Original file line numberDiff line numberDiff line change
@@ -142,3 +142,21 @@ jobs:
142142
run: pip3 install --user html5validator==0.4.2
143143
- name: Run html5validator
144144
run: ./src/main/scripts/execute-command.sh html5validator
145+
run-enforcer:
146+
name: Run maven-enforcer-plugin
147+
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
148+
runs-on: ubuntu-20.04
149+
steps:
150+
- name: Clone source code
151+
uses: actions/[email protected] # https://github.com/actions/checkout
152+
with:
153+
# Whether to configure the token or SSH key with the local git config. Default: true
154+
persist-credentials: false
155+
- name: Install JDK
156+
uses: actions/[email protected] # https://github.com/actions/setup-java
157+
with:
158+
distribution: 'adopt' # https://github.com/actions/setup-java#supported-distributions
159+
java-version: '8' # https://github.com/actions/setup-java#supported-version-syntax
160+
cache: 'maven' # https://github.com/actions/setup-java#caching-packages-dependencies
161+
- name: Run maven-enforcer-plugin
162+
run: ./src/main/scripts/execute-command.sh enforcer

src/main/scripts/ci/check-build-and-verify.sh

+2-14
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ if [ "${1:-}" = '--only-integration-tests' ]; then
5858
RUN_ONLY_INTEGRATION_TESTS=yes
5959
fi
6060

61-
ENFORCER_STATUS=
6261
TEST_STATUS=
6362
CODENARC_STATUS=
6463
SPOTBUGS_STATUS=
@@ -70,7 +69,6 @@ if [ "${SPRING_PROFILES_ACTIVE:-}" = 'travis' ] && [ "${TRAVIS_PULL_REQUEST:-fal
7069
DANGER_STATUS=
7170
fi
7271

73-
ENFORCER_TIME=0
7472
TEST_TIME=0
7573
CODENARC_TIME=0
7674
SPOTBUGS_TIME=0
@@ -104,8 +102,6 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
104102
AFFECTS_PLAYBOOKS="$(echo "$MODIFIED_FILES" | grep -Eq '(vagrant|prod|deploy|bootstrap|/roles/.+)\.yml$' || echo 'no')"
105103

106104
if [ "$AFFECTS_POM_XML" = 'no' ]; then
107-
ENFORCER_STATUS=skip
108-
109105
if [ "$AFFECTS_JAVA_FILES" = 'no' ]; then
110106
[ "$AFFECTS_SPOTBUGS_CFG" != 'no' ] || SPOTBUGS_STATUS=skip
111107

@@ -135,13 +131,6 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
135131

136132
echo
137133

138-
if [ "$ENFORCER_STATUS" != 'skip' ]; then
139-
START_TIME=$SECONDS
140-
"$EXEC_CMD" enforcer >enforcer.log 2>&1 || ENFORCER_STATUS=fail
141-
ENFORCER_TIME=$((SECONDS - START_TIME))
142-
fi
143-
print_status "$ENFORCER_STATUS" "$ENFORCER_TIME" 'Run maven-enforcer-plugin'
144-
145134
if [ "$TEST_STATUS" != 'skip' ]; then
146135
START_TIME=$SECONDS
147136
"$EXEC_CMD" unit-tests >test.log 2>&1 || TEST_STATUS=fail
@@ -188,7 +177,6 @@ fi
188177
print_status "$DANGER_STATUS" "$DANGER_TIME" 'Run danger'
189178

190179
if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
191-
[ "$ENFORCER_STATUS" = 'skip' ] || print_log enforcer.log 'Run maven-enforcer-plugin'
192180
[ "$TEST_STATUS" = 'skip' ] || print_log test.log 'Run unit tests'
193181
[ "$CODENARC_STATUS" = 'skip' ] || print_log codenarc.log 'Run CodeNarc'
194182
[ "$SPOTBUGS_STATUS" = 'skip' ] || print_log spotbugs.log 'Run SpotBugs'
@@ -201,8 +189,8 @@ if [ "$DANGER_STATUS" != 'skip' ]; then
201189
print_log danger.log 'Run danger'
202190
fi
203191

204-
rm -f enforcer.log test.log codenarc.log spotbugs.log verify.log danger.log ansible_lint.log
192+
rm -f test.log codenarc.log spotbugs.log verify.log danger.log ansible_lint.log
205193

206-
if echo "$ENFORCER_STATUS$TEST_STATUS$CODENARC_STATUS$SPOTBUGS_STATUS$VERIFY_STATUS$DANGER_STATUS$ANSIBLE_LINT_STATUS" | grep -Fqs 'fail'; then
194+
if echo "$TEST_STATUS$CODENARC_STATUS$SPOTBUGS_STATUS$VERIFY_STATUS$DANGER_STATUS$ANSIBLE_LINT_STATUS" | grep -Fqs 'fail'; then
207195
exit 1
208196
fi

0 commit comments

Comments
 (0)