Simplify Spring's @RequestMapping for GET requests.

Automated with the following one-liners:
git grep -l 'import.*RequestMethod' | while read F; do grep -q 'RequestMethod.POST' "$F" || sed -i '/import.*RequestMethod/d' "$F"; done
git grep -l 'RequestMethod\.GET' | xargs sed -i 's|(value = \([^,]\+\), method = RequestMethod.GET)|(\1)|'

No functional changes.

Author: php-coder

src/main/config/checkstyle-suppressions.xml

@@ -8,7 +8,7 @@
 	<suppress checks="LineLength" files="AbstractPageWithForm.java" lines="27,28,33" />
 	<suppress checks="LineLength" files="Form.java" lines="31,32,37" />
 	<suppress checks="LineLength" files="Url.java" lines="73" />
-	<suppress checks="LineLength" files="ErrorController.java" lines="74" />
+	<suppress checks="LineLength" files="ErrorController.java" lines="73" />
 
 	<!-- false positives due to Lombok usage -->
 	<suppress checks="HideUtilityClassConstructor" files="ru.mystamps.web.model" />

src/main/java/ru/mystamps/web/controller/AccountController.java

@@ -62,7 +62,7 @@ protected void activationInitBinder(WebDataBinder binder) {
 		binder.registerCustomEditor(String.class, "name", new StringTrimmerEditor(true));
 	}
 
-	@RequestMapping(value = Url.REGISTRATION_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.REGISTRATION_PAGE)
 	public RegisterAccountForm showRegistrationForm() {
 		return new RegisterAccountForm();
 	}
@@ -85,12 +85,12 @@ public String processRegistrationForm(
 		return "redirect:" + Url.ACTIVATE_ACCOUNT_PAGE;
 	}
 
-	@RequestMapping(value = Url.ACTIVATE_ACCOUNT_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.ACTIVATE_ACCOUNT_PAGE)
 	public ActivateAccountForm showActivationForm() {
 		return new ActivateAccountForm();
 	}
 
-	@RequestMapping(value = Url.ACTIVATE_ACCOUNT_PAGE_WITH_KEY, method = RequestMethod.GET)
+	@RequestMapping(Url.ACTIVATE_ACCOUNT_PAGE_WITH_KEY)
 	public String showActivationFormWithKey(
 		@PathVariable("key") String activationKey,
 		Model model) {

src/main/java/ru/mystamps/web/controller/CategoryController.java

@@ -56,7 +56,7 @@ protected void initBinder(WebDataBinder binder) {
 		binder.registerCustomEditor(String.class, "nameRu", editor);
 	}
 
-	@RequestMapping(value = Url.ADD_CATEGORY_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.ADD_CATEGORY_PAGE)
 	public AddCategoryForm showForm() {
 		return new AddCategoryForm();
 	}
@@ -80,7 +80,7 @@ public String processInput(
 		return "redirect:" + dstUrl;
 	}
 
-	@RequestMapping(value = Url.INFO_CATEGORY_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.INFO_CATEGORY_PAGE)
 	public String showInfo(@PathVariable("id") Category category, Model model, Locale userLocale) {
 
 		if (category == null) {

src/main/java/ru/mystamps/web/controller/CollectionController.java

@@ -25,7 +25,6 @@
 import org.springframework.ui.Model;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestMethod;
 
 import lombok.RequiredArgsConstructor;
 
@@ -46,7 +45,7 @@ public class CollectionController {
 	private final SeriesService seriesService;
 	private final MessageSource messageSource;
 
-	@RequestMapping(value = Url.INFO_COLLECTION_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.INFO_COLLECTION_PAGE)
 	public String showInfo(
 		@PathVariable("id") Collection collection,
 		Model model,

src/main/java/ru/mystamps/web/controller/CountryController.java

@@ -56,7 +56,7 @@ protected void initBinder(WebDataBinder binder) {
 		binder.registerCustomEditor(String.class, "nameRu", editor);
 	}
 
-	@RequestMapping(value = Url.ADD_COUNTRY_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.ADD_COUNTRY_PAGE)
 	public AddCountryForm showForm() {
 		return new AddCountryForm();
 	}
@@ -77,7 +77,7 @@ public String processInput(@Valid AddCountryForm form, BindingResult result, Use
 		return "redirect:" + dstUrl;
 	}
 
-	@RequestMapping(value = Url.INFO_COUNTRY_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.INFO_COUNTRY_PAGE)
 	public String showInfo(@PathVariable("id") Country country, Model model, Locale userLocale) {
 
 		if (country == null) {

src/main/java/ru/mystamps/web/controller/ErrorController.java

@@ -25,7 +25,6 @@
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestHeader;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestMethod;
 
 import lombok.RequiredArgsConstructor;
 
@@ -41,7 +40,7 @@ public class ErrorController {
 
 	private final SiteService siteService;
 
-	@RequestMapping(value = Url.NOT_FOUND_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.NOT_FOUND_PAGE)
 	public void notFound(
 			HttpServletRequest request,
 			CustomUserDetails userDetails,
@@ -66,7 +65,7 @@ public void notFound(
 		}
 	}
 
-	@RequestMapping(value = Url.INTERNAL_ERROR_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.INTERNAL_ERROR_PAGE)
 	public void internalError(HttpServletRequest request) {
 		// TODO: log to database (with *.status_code, *.message, *.servlet_name and user details)
 

src/main/java/ru/mystamps/web/controller/ImageController.java

@@ -24,7 +24,6 @@
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestMethod;
 
 import lombok.RequiredArgsConstructor;
 
@@ -38,7 +37,7 @@ public class ImageController {
 
 	private final ImageService imageService;
 
-	@RequestMapping(value = Url.GET_IMAGE_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.GET_IMAGE_PAGE)
 	public void getImage(@PathVariable("id") Integer imageId, HttpServletResponse response)
 		throws IOException {
 

src/main/java/ru/mystamps/web/controller/RobotsTxtController.java

@@ -27,15 +27,14 @@
 
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestMethod;
 
 import ru.mystamps.web.Url;
 
 @Controller
 public class RobotsTxtController {
 	private static final Logger LOG = LoggerFactory.getLogger(RobotsTxtController.class);
 
-	@RequestMapping(value = Url.ROBOTS_TXT, method = RequestMethod.GET)
+	@RequestMapping(Url.ROBOTS_TXT)
 	@SuppressWarnings("PMD.AvoidDuplicateLiterals")
 	public void getRobotsText(HttpServletResponse response) {
 		response.setContentType("text/plain");

src/main/java/ru/mystamps/web/controller/SeriesController.java

@@ -109,7 +109,7 @@ public Iterable<SelectEntityDto> getCountries(Locale userLocale) {
 		return countryService.findAll(lang);
 	}
 
-	@RequestMapping(value = Url.ADD_SERIES_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.ADD_SERIES_PAGE)
 	public AddSeriesForm showForm() {
 
 		AddSeriesForm addSeriesForm = new AddSeriesForm();
@@ -145,7 +145,7 @@ public String processInput(
 		return "redirect:" + dstUrl;
 	}
 
-	@RequestMapping(value = Url.INFO_SERIES_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.INFO_SERIES_PAGE)
 	public String showInfo(@PathVariable("id") Series series, Model model, User currentUser) {
 
 		if (series == null) {

src/main/java/ru/mystamps/web/controller/SiteController.java

@@ -22,7 +22,6 @@
 import org.springframework.stereotype.Controller;
 import org.springframework.ui.Model;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestMethod;
 
 import lombok.RequiredArgsConstructor;
 
@@ -45,7 +44,7 @@ public class SiteController {
 	private final CountryService countryService;
 	private final SeriesService seriesService;
 
-	@RequestMapping(value = Url.INDEX_PAGE, method = RequestMethod.GET)
+	@RequestMapping(Url.INDEX_PAGE)
 	public String showIndexPage(Model model, Locale userLocale) {
 		model.addAttribute("categoryCounter", categoryService.countAll());
 		model.addAttribute("countryCounter", countryService.countAll());