Skip to content

Commit e6ed0e8

Browse files
committed
build: suppress warnings/errors in integration tests that are produced by htmlunit.
These messages aren't real errors and there a lot of them, so we suppress them to not confuse developers and to make a build log short and concise. See for details: - https://maven.apache.org/maven-logging.html - http://www.slf4j.org/api/org/slf4j/impl/SimpleLogger.html - https://github.com/apache/maven/blob/a6f113abced80defc4c5d0b60e2d085b8306b274/apache-maven/src/conf/logging/simplelogger.properties Hint: in order to identify logger name, specify -Dorg.slf4j.simpleLogger.showLogName=true Fix #538
1 parent 6623047 commit e6ed0e8

File tree

3 files changed

+5
-49
lines changed

3 files changed

+5
-49
lines changed

.mvn/jvm.config

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
-Dorg.slf4j.simpleLogger.log.com.gargoylesoftware.htmlunit.DefaultCssErrorHandler=error
2+
-Dorg.slf4j.simpleLogger.log.com.gargoylesoftware.htmlunit.html.InputElementFactory=warn
3+
-Dorg.slf4j.simpleLogger.log.com.gargoylesoftware.htmlunit.IncorrectnessListenerImpl=error

src/main/scripts/ci/check-build-and-verify.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,9 +260,7 @@ if [ "$RUN_ONLY_INTEGRATION_TESTS" = 'no' ]; then
260260
fi
261261

262262
mvn --batch-mode --activate-profiles frontend,native2ascii verify -Denforcer.skip=true -DskipUnitTests=true \
263-
>verify-raw.log 2>&1 || VERIFY_STATUS=fail
264-
# Workaround for #538
265-
"$(dirname "$0")/filter-out-htmlunit-messages.pl" <verify-raw.log >verify.log
263+
>verify.log 2>&1 || VERIFY_STATUS=fail
266264

267265
print_status "$VERIFY_STATUS" 'Run integration tests'
268266

@@ -295,7 +293,7 @@ if [ "$DANGER_STATUS" != 'skip' ]; then
295293
print_log danger.log 'Run danger'
296294
fi
297295

298-
rm -f cs.log pmd.log license.log pom.log bootlint.log rflint.log shellcheck.log jasmine.log validator.log enforcer.log test.log codenarc.log spotbugs.log verify-raw.log verify.log danger.log ansible_lint.log
296+
rm -f cs.log pmd.log license.log pom.log bootlint.log rflint.log shellcheck.log jasmine.log validator.log enforcer.log test.log codenarc.log spotbugs.log verify.log danger.log ansible_lint.log
299297

300298
if echo "$CS_STATUS$PMD_STATUS$LICENSE_STATUS$POM_STATUS$BOOTLINT_STATUS$RFLINT_STATUS$SHELLCHECK_STATUS$JASMINE_STATUS$HTML_STATUS$ENFORCER_STATUS$TEST_STATUS$CODENARC_STATUS$SPOTBUGS_STATUS$VERIFY_STATUS$DANGER_STATUS$ANSIBLE_LINT_STATUS" | grep -Fqs 'fail'; then
301299
exit 1

src/main/scripts/ci/filter-out-htmlunit-messages.pl

Lines changed: 0 additions & 45 deletions
This file was deleted.

0 commit comments

Comments
 (0)