style: use FIXME in comments instead of TODO to unbreak 0pdd.

Adapt code base to backward incompatible changes in pdd/0pdd.
See: yegor256/0pdd#260

No code changes.

Author: php-coder

Dangerfile

@@ -239,7 +239,7 @@ if File.file?(bootlint_output)
 		file   = github.html_link("#{file}#L#{lineno}")
 		fail("bootlint error in #{file}:\n[#{code}](https://github.com/twbs/bootlint/wiki/#{code}): #{msg}")
 	end
-	# TODO: add link to wiki page (#316)
+	# FIXME: add link to wiki page (#316)
 	print_errors_summary 'bootlint', errors_count
 end
 
@@ -292,7 +292,7 @@ if File.file?(shellcheck_output)
 		file   = github.html_link("#{file}#L#{lineno}")
 		fail("shellcheck error in #{file}:\n[#{code}](https://github.com/koalaman/shellcheck/wiki/#{code}): #{msg}")
 	end
-	# TODO: add link to wiki page
+	# FIXME: add link to wiki page
 	print_errors_summary 'shellcheck', errors_count
 end
 
@@ -395,7 +395,7 @@ if File.file?(validator_output)
 		fail("html5validator error in #{file}:\n#{msg}")
 	end
 
-	# TODO: add link to wiki page (#541)
+	# FIXME: add link to wiki page (#541)
 	print_errors_summary 'html5validator', errors_count
 end
 
@@ -654,7 +654,7 @@ if File.file?(rf_report)
 		file = github.html_link("#{file}#{line}")
 		fail("robotframework-maven-plugin error in #{file}:\nTest case `#{testcase}` fails with message:\n#{msg}")
 	end
-	# TODO: add link to wiki page (#530)
+	# FIXME: add link to wiki page (#530)
 	print_errors_summary 'robotframework-maven-plugin', errors_count
 end
 
@@ -690,7 +690,7 @@ if File.file?(failsafe_report)
 			file = github.html_link(file)
 			testcase = clazz.split('.')[-1] + '.' + node['name']
 			msg = node.xpath('./exception/message').text.strip
-			# TODO: highlight line number
+			# FIXME: highlight line number
 			fail("maven-failsafe-plugin error in #{file}:\nTest case `#{testcase}` fails with error:\n#{msg}")
 		end
 

docker/Dockerfile

@@ -16,7 +16,7 @@ ENV SPRING_PROFILES_ACTIVE=test
 #   See also: https://docs.docker.com/engine/reference/builder/#run
 #   NOTE: /data/uploads and /data/preview are being used only in "prod" profile.
 # - Setting up a timezone to Moscow time.
-#   TODO: remove when #76 will be resolved and application will use UTC timezone.
+#   FIXME: remove when #76 will be resolved and application will use UTC timezone.
 RUN mkdir /data \
  && useradd mystamps --home-dir /data/mystamps --create-home --comment 'MyStamps' \
  && mkdir /data/uploads /data/preview /data/heap-dumps \

docker/prod.yml

@@ -29,7 +29,7 @@ services:
       # the generated root password will be printed to stdout (GENERATED ROOT PASSWORD: ...)
       - MYSQL_RANDOM_ROOT_PASSWORD=true
       - MYSQL_USER=mystamps
-      # TODO: try to use a secret
+      # FIXME: try to use a secret
       - MYSQL_PASSWORD=secret
       # the user specified above will be granted superuser access automatically
       - MYSQL_DATABASE=mystamps

pom.xml

@@ -726,7 +726,7 @@
 				<version>${dockerfile.plugin.version}</version>
 				<configuration>
 					<repository>phpcoder/mystamps</repository>
-					<!-- TODO: set it to docker/ after https://github.com/spotify/dockerfile-maven/pull/89 will be merged -->
+					<!-- FIXME: set it to docker/ after https://github.com/spotify/dockerfile-maven/pull/89 will be merged -->
 					<contextDirectory>target</contextDirectory>
 				</configuration>
 			</plugin>
@@ -859,7 +859,7 @@
 				<artifactId>maven-resources-plugin</artifactId>
 				<version>${resources.plugin.version}</version>
 				<executions>
-					<!-- TODO: remove this workaround after merging https://github.com/spotify/dockerfile-maven/pull/89 -->
+					<!-- FIXME: remove this workaround after merging https://github.com/spotify/dockerfile-maven/pull/89 -->
 					<execution>
 						<id>copy-docker-resources</id>
 						<goals>

src/main/java/ru/mystamps/web/Url.java

@@ -110,7 +110,7 @@ public final class Url {
 	public static final String BOOTSTRAP_LANGUAGE     = "https://cdn.rawgit.com/usrz/bootstrap-languages/3ac2a3d2b27ac43a471cd99e79d378a03b2c6b5f/languages.min.css";
 
 	// CheckStyle: ignore LineLength for next 3 lines
-	// TODO: use minimal version of CSS file when it will be available (https://github.com/webjars/selectize.js/issues/3)
+	// FIXME: use minimal version of CSS file when it will be available (https://github.com/webjars/selectize.js/issues/3)
 	public static final String SELECTIZE_CSS          = "/public/selectize/0.12.4/css/selectize.bootstrap3.css";
 	public static final String SELECTIZE_JS           = "/public/selectize/0.12.4/js/standalone/selectize.min.js";
 

src/main/java/ru/mystamps/web/controller/ErrorController.java

@@ -50,7 +50,7 @@ public void notFound(
 			@RequestHeader(name = "referer", required = false) String referer,
 			@RequestHeader(name = "user-agent", required = false) String agent) {
 
-		// TODO: sanitize all user's values (#60)
+		// FIXME: sanitize all user's values (#60)
 		String ip     = request.getRemoteAddr();
 		String method = request.getMethod();
 
@@ -64,7 +64,7 @@ public void internalError(
 		@RequestAttribute(name = RequestDispatcher.ERROR_EXCEPTION, required = false) Exception exception,
 		@RequestAttribute(name = RequestDispatcher.ERROR_REQUEST_URI, required = false) String page) {
 
-		// TODO: log to database (with *.status_code, *.message, *.servlet_name and user details)
+		// FIXME: log to database (with *.status_code, *.message, *.servlet_name and user details)
 
 		if (page != null && !Url.INTERNAL_ERROR_PAGE.equals(page)) {
 			LOG.error(

src/main/java/ru/mystamps/web/controller/SitemapController.java

@@ -42,7 +42,7 @@
 public class SitemapController {
 	private static final Logger LOG = LoggerFactory.getLogger(SitemapController.class);
 
-	// TODO: convert dates to UTC and omit server-specific timezone part
+	// FIXME: convert dates to UTC and omit server-specific timezone part
 	// According to http://www.w3.org/TR/NOTE-datetime
 	private static final String DATE_FORMAT = "yyyy-MM-dd'T'HH:mmXXX";
 

src/main/java/ru/mystamps/web/controller/interceptor/DownloadImageInterceptor.java

@@ -114,7 +114,7 @@ public boolean preHandle(
 		}
 
 		if (!SecurityContextUtils.hasAuthority(Authority.DOWNLOAD_IMAGE)) {
-			// TODO(security): fix possible log injection
+			// FIXME(security): fix possible log injection
 			LOG.warn(
 				"User #{} without permissions has tried to download a file from '{}'",
 				SecurityContextUtils.getUserId(),

src/main/java/ru/mystamps/web/feature/category/CategoryServiceImpl.java

@@ -103,7 +103,7 @@ public List<Integer> findIdsByNames(List<String> names) {
 	public List<Integer> findIdsWhenNameStartsWith(String name) {
 		Validate.isTrue(StringUtils.isNotBlank(name), "Name must be non-blank");
 
-		// TODO: escape % and _ chars in name
+		// FIXME: escape % and _ chars in name
 		Validate.isTrue(
 			!StringUtils.containsAny(name, '%', '_'),
 			"Name must not contain '%' or '_' chars"

src/main/java/ru/mystamps/web/feature/collection/CollectionController.java

@@ -112,7 +112,7 @@ public String showPrices(
 			return null;
 		}
 
-		// TODO: we need only ownerName, without id and slug
+		// FIXME: we need only ownerName, without id and slug
 		CollectionInfoDto collection = collectionService.findBySlug(slug);
 		if (collection == null) {
 			response.sendError(HttpServletResponse.SC_NOT_FOUND);

src/main/java/ru/mystamps/web/feature/collection/CollectionServiceImpl.java

@@ -193,7 +193,7 @@ public CollectionInfoDto findBySlug(String slug) {
 	private static String formatSeriesInfo(AddToCollectionDbDto collectionDto) {
 		StringBuilder sb = new StringBuilder();
 
-		// TODO: it would be good to include number of stamps in series vs in collection
+		// FIXME: it would be good to include number of stamps in series vs in collection
 		sb.append("stamps=")
 			.append(collectionDto.getNumberOfStamps());
 

src/main/java/ru/mystamps/web/feature/country/CountryServiceImpl.java

@@ -103,7 +103,7 @@ public List<Integer> findIdsByNames(List<String> names) {
 	public List<Integer> findIdsWhenNameStartsWith(String name) {
 		Validate.isTrue(StringUtils.isNotBlank(name), "Name must be non-blank");
 
-		// TODO: escape % and _ chars in name
+		// FIXME: escape % and _ chars in name
 		Validate.isTrue(
 			!StringUtils.containsAny(name, '%', '_'),
 			"Name must not contain '%' or '_' chars"

src/main/java/ru/mystamps/web/feature/image/FilesystemImagePersistenceStrategy.java

@@ -51,7 +51,7 @@ public void init() {
 
 		} else if (!storageDir.canWrite()) {
 			log.warn(
-				// TODO(java9): log also user: ProcessHandle.current().info().user()
+				// FIXME(java9): log also user: ProcessHandle.current().info().user()
 				"Directory '{}' exists but isn't writable for the current user! "
 				+ "Image uploading won't work.",
 				storageDir
@@ -67,7 +67,7 @@ public void init() {
 			);
 
 		} else if (!previewDir.canWrite()) {
-			// TODO(java9): log also user: ProcessHandle.current().info().user()
+			// FIXME(java9): log also user: ProcessHandle.current().info().user()
 			log.warn(
 				"Directory '{}' exists but isn't writable for the current user! "
 				+ "Image preview generation won't work",
@@ -177,7 +177,7 @@ private ImageDto get(File dir, ImageInfoDto image, boolean logWarning) {
 	}
 
 	private static String generateFileName(ImageInfoDto image) {
-		// TODO(performance): specify initial capacity explicitly
+		// FIXME(performance): specify initial capacity explicitly
 		return new StringBuilder()
 			.append(image.getId())
 			.append('.')

src/main/java/ru/mystamps/web/feature/image/ImageController.java

@@ -51,7 +51,7 @@ public void getImage(@PathVariable("id") Integer imageId, HttpServletResponse re
 			return;
 		}
 
-		// TODO: set content disposition
+		// FIXME: set content disposition
 		response.setContentType("image/" + image.getType().toLowerCase(Locale.ENGLISH));
 		response.setContentLength(image.getData().length);
 

src/main/java/ru/mystamps/web/feature/image/ImageServiceImpl.java

@@ -175,7 +175,7 @@ private String abbreviateIfLengthGreaterThan(String text, int maxLength) {
 			return text;
 		}
 
-		// TODO(security): fix possible log injection
+		// FIXME(security): fix possible log injection
 		log.warn(
 			"Length of value for 'filename' field ({}) exceeds max field size ({}): '{}'",
 			text.length(),

src/main/java/ru/mystamps/web/feature/participant/AddParticipantForm.java

@@ -45,8 +45,8 @@ public class AddParticipantForm implements AddParticipantDto {
 	@Size(max = PARTICIPANT_URL_MAX_LENGTH, message = "{value.too-long}")
 	private String url;
 
-	// TODO: must be positive
-	// TODO: must be existing group
+	// FIXME: must be positive
+	// FIXME: must be existing group
 	private Integer groupId;
 
 	@NotNull

src/main/java/ru/mystamps/web/feature/series/JdbcSeriesDao.java

@@ -36,7 +36,7 @@
 
 import ru.mystamps.web.support.jdbc.RowMappers;
 
-// TODO: move stamps related methods to separate interface (#88)
+// FIXME: move stamps related methods to separate interface (#88)
 @SuppressWarnings({
 	"PMD.AvoidDuplicateLiterals",
 	"PMD.TooManyMethods",

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

@@ -664,7 +664,7 @@ private static void addImageFormToModel(Model model) {
 	}
 
 	private static void addStampsToCollectionForm(Model model, SeriesDto series) {
-		// TODO: only add when isSeriesInCollection
+		// FIXME: only add when isSeriesInCollection
 		if (model.containsAttribute("addToCollectionForm")) {
 			return;
 		}

src/main/java/ru/mystamps/web/feature/series/SeriesDao.java

@@ -20,7 +20,7 @@
 import java.util.Date;
 import java.util.List;
 
-// TODO: move stamps related methods to separate interface (#88)
+// FIXME: move stamps related methods to separate interface (#88)
 @SuppressWarnings("PMD.TooManyMethods")
 public interface SeriesDao {
 	Integer add(AddSeriesDbDto series);

src/main/java/ru/mystamps/web/feature/series/SeriesService.java

@@ -20,7 +20,7 @@
 import java.util.Date;
 import java.util.List;
 
-// TODO: move stamps related methods to separate interface (#88)
+// FIXME: move stamps related methods to separate interface (#88)
 @SuppressWarnings("PMD.TooManyMethods")
 public interface SeriesService {
 	Integer add(AddSeriesDto dto, Integer userId, boolean userCanAddComments);

src/main/java/ru/mystamps/web/feature/series/SeriesServiceImpl.java

@@ -38,7 +38,7 @@
 import ru.mystamps.web.support.spring.security.HasAuthority;
 import ru.mystamps.web.util.CatalogUtils;
 
-// TODO: move stamps related methods to separate interface (#88)
+// FIXME: move stamps related methods to separate interface (#88)
 // The String literal "Series id must be non null" appears N times in this file
 // and we think that it's OK.
 @SuppressWarnings({ "PMD.TooManyMethods", "PMD.AvoidDuplicateLiterals" })

src/main/java/ru/mystamps/web/feature/series/importing/event/DownloadingSucceededEventListener.java

@@ -67,14 +67,14 @@ public void onApplicationEvent(DownloadingSucceeded event) {
 
 		SiteParser parser = siteParserService.findForUrl(event.getUrl());
 		if (parser == null) {
-			// TODO: how to handle error? maybe publish UnexpectedErrorEvent?
+			// FIXME: how to handle error? maybe publish UnexpectedErrorEvent?
 			log.error("Request #{}: could not find appropriate parser", requestId);
 			return;
 		}
 
 		String content = seriesImportService.getDownloadedContent(requestId);
 		if (content == null) {
-			// TODO: how to handle error? maybe publish UnexpectedErrorEvent?
+			// FIXME: how to handle error? maybe publish UnexpectedErrorEvent?
 			log.error("Request #{}: could not load a content from database", requestId);
 			return;
 		}

src/main/java/ru/mystamps/web/feature/series/importing/event/ParsingFailedEventListener.java

@@ -42,7 +42,7 @@ public class ParsingFailedEventListener
 	public void onApplicationEvent(ParsingFailed event) {
 		Integer requestId = event.getRequestId();
 
-		// TODO: more info?
+		// FIXME: more info?
 		log.info("Request #{}: parsing failed", requestId);
 
 		seriesImportService.changeStatus(

src/main/java/ru/mystamps/web/service/HttpURLConnectionDownloaderService.java

@@ -50,13 +50,13 @@ public class HttpURLConnectionDownloaderService implements DownloaderService {
 		LoggerFactory.getLogger(HttpURLConnectionDownloaderService.class);
 
 	// We don't support redirects because they allow to bypass some of our validations.
-	// TODO: How exactly redirects can harm?
+	// FIXME: How exactly redirects can harm?
 	@SuppressWarnings({"PMD.RedundantFieldInitializer", "PMD.ImmutableField"})
 	private boolean followRedirects = false;
 
 	// Only types listed here will be downloaded. For other types, INVALID_FILE_TYPE error
 	// will be returned. An empty array (or null) means that all types are allowed.
-	// TODO: at this moment we do a case sensitive comparison. Should we change it?
+	// FIXME: at this moment we do a case sensitive comparison. Should we change it?
 	private final String[] allowedContentTypes;
 
 	// Max time to wait during opening a connection to a resource (in milliseconds).
@@ -67,7 +67,7 @@ public class HttpURLConnectionDownloaderService implements DownloaderService {
 	@Override
 	@PreAuthorize(HasAuthority.DOWNLOAD_IMAGE)
 	public DownloadResult download(String fileUrl) {
-		// TODO(security): fix possible log injection
+		// FIXME(security): fix possible log injection
 		LOG.debug("Downloading '{}'", fileUrl);
 
 		try {
@@ -93,7 +93,7 @@ public DownloadResult download(String fileUrl) {
 					return DownloadResult.failed(validationResult);
 				}
 
-				// TODO(java9): use InputStream.readAllBytes()
+				// FIXME(java9): use InputStream.readAllBytes()
 				byte[] data = StreamUtils.copyToByteArray(stream);
 				String contentType = conn.getContentType();
 				return DownloadResult.succeeded(data, contentType);
@@ -130,7 +130,7 @@ private static HttpURLConnection openConnection(URL url) throws IOException {
 	}
 
 	private static void configureUserAgent(URLConnection conn) {
-		// TODO: make it configurable
+		// FIXME: make it configurable
 		conn.setRequestProperty(
 			"User-Agent",
 			"Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0"
@@ -181,7 +181,7 @@ private Code validateConnection(HttpURLConnection conn) throws IOException {
 		contentType = StringUtils.substringBefore(contentType, ";");
 
 		if (allowedContentTypes != null && !ArrayUtils.contains(allowedContentTypes, contentType)) {
-			// TODO(security): fix possible log injection
+			// FIXME(security): fix possible log injection
 			LOG.debug("Couldn't download file: unsupported file type '{}'", contentType);
 			return Code.INVALID_FILE_TYPE;
 		}

src/main/java/ru/mystamps/web/service/ReportServiceImpl.java

@@ -74,7 +74,7 @@ public String prepareDailyStatistics(AdminDailyReport report) {
 		put(ctx, "failed_auth_cnt", report.getFailedAuthCounter());
 		put(ctx, "missing_csrf_cnt", report.getMissingCsrfCounter());
 		put(ctx, "invalid_csrf_cnt", report.getInvalidCsrfCounter());
-		put(ctx, "bad_request_cnt", -1L);  // TODO: #122
+		put(ctx, "bad_request_cnt", -1L);  // FIXME: #122
 
 		return new StringSubstitutor(ctx).replace(template);
 	}

src/main/java/ru/mystamps/web/service/SiteServiceImpl.java

@@ -187,7 +187,7 @@ private String abbreviateIfLengthGreaterThan(String text, int maxLength, String
 			return text;
 		}
 
-		// TODO(security): fix possible log injection
+		// FIXME(security): fix possible log injection
 		log.warn(
 				"Length of '{}' exceeds max length for '{}' field: {} > {}",
 				text,

src/main/java/ru/mystamps/web/support/beanvalidation/FieldsMatchValidator.java

@@ -59,7 +59,7 @@ public boolean isValid(Object value, ConstraintValidatorContext ctx) {
 			return true;
 		}
 
-		// TODO: check fields only when both fields are equals
+		// FIXME: check fields only when both fields are equals
 
 		if (!firstFieldValue.equals(secondFieldValue)) {
 			// bind error message to 2nd field

src/main/java/ru/mystamps/web/support/beanvalidation/FieldsMismatchValidator.java

@@ -59,7 +59,7 @@ public boolean isValid(Object value, ConstraintValidatorContext ctx) {
 			return true;
 		}
 
-		// TODO: check fields only when both fields are equals
+		// FIXME: check fields only when both fields are equals
 
 		if (firstFieldValue.equals(secondFieldValue)) {
 			// bind error message to 2nd field

src/main/java/ru/mystamps/web/support/beanvalidation/ImageFileValidator.java

@@ -55,7 +55,7 @@ public class ImageFileValidator implements ConstraintValidator<ImageFile, Multip
 	};
 
 	private static boolean isJpeg(byte[] bytes) {
-		// TODO: also check that last 2 bytes are FF D9 (use RandomAccessFile)
+		// FIXME: also check that last 2 bytes are FF D9 (use RandomAccessFile)
 
 		for (byte[] signature: JPEG_SIGNATURES) {
 			if (Arrays.equals(bytes, signature)) {

src/main/java/ru/mystamps/web/support/spring/security/AuthenticationFailureListener.java

@@ -50,8 +50,8 @@ public void onApplicationEvent(AuthenticationFailureBadCredentialsEvent event) {
 			return;
 		}
 
-		// TODO: log more info (login for example) (#59)
-		// TODO: sanitize all user's values (#60)
+		// FIXME: log more info (login for example) (#59)
+		// FIXME: sanitize all user's values (#60)
 		String method  = request.getMethod();
 		String page    = request.getRequestURI();
 		String ip      = request.getRemoteAddr();