SeriesSalesImportServiceImpl.saveParsedData(): add unit tests.

Fix #834

Author: php-coder

src/main/java/ru/mystamps/web/service/SeriesSalesImportServiceImpl.java

@@ -35,7 +35,7 @@ public class SeriesSalesImportServiceImpl implements SeriesSalesImportService {
 	private final Logger log;
 	private final SeriesSalesImportDao seriesSalesImportDao;
 
-	// @todo #695 SeriesSalesImportServiceImpl.saveParsedData(): add unit tests
+	// @todo #834 SeriesSalesImportServiceImpl.saveParsedData(): introduce dto without dates
 	@Override
 	@Transactional
 	public void saveParsedData(Integer requestId, SeriesSalesParsedDataDbDto data) {

src/test/groovy/ru/mystamps/web/service/SeriesSalesImportServiceImplTest.groovy

@@ -0,0 +1,69 @@
+/**
+ * Copyright (C) 2009-2018 Slava Semushin <slava.semushin@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+package ru.mystamps.web.service
+
+import org.slf4j.helpers.NOPLogger
+
+import spock.lang.Specification
+
+import ru.mystamps.web.dao.SeriesSalesImportDao
+import ru.mystamps.web.dao.dto.SeriesSalesParsedDataDbDto
+import ru.mystamps.web.tests.Random
+
+@SuppressWarnings(['ClassJavadoc', 'MethodName', 'NoDef', 'NoTabCharacter', 'TrailingWhitespace'])
+class SeriesSalesImportServiceImplTest extends Specification {
+	
+	private final SeriesSalesImportDao seriesSalesImportDao = Mock()
+	
+	private SeriesSalesImportService service
+	
+	def setup() {
+		service = new SeriesSalesImportServiceImpl(NOPLogger.NOP_LOGGER, seriesSalesImportDao)
+	}
+	
+	//
+	// Tests for saveParsedData()
+	//
+	
+	def 'saveParsedData() should throw exception when request id is null'() {
+		when:
+			service.saveParsedData(null, TestObjects.createSeriesSalesParsedDataDbDto())
+		then:
+			IllegalArgumentException ex = thrown()
+			ex.message == 'Request id must be non null'
+	}
+	
+	def 'saveParsedData() should throw exception when parsed data is null'() {
+		when:
+			service.saveParsedData(Random.id(), null)
+		then:
+			IllegalArgumentException ex = thrown()
+			ex.message == 'Parsed data must be non null'
+	}
+	
+	def 'saveParsedData() should save series parsed data'() {
+		given:
+			Integer expectedRequestId = Random.id()
+			SeriesSalesParsedDataDbDto expectedParsedData = TestObjects.createSeriesSalesParsedDataDbDto()
+		when:
+			service.saveParsedData(expectedRequestId, expectedParsedData)
+		then:
+			1 * seriesSalesImportDao.addParsedData(expectedRequestId, expectedParsedData)
+	}
+	
+}

src/test/java/ru/mystamps/web/service/TestObjects.java

@@ -286,4 +286,14 @@ public static SeriesExtractedInfo createEmptySeriesExtractedInfo() {
 		);
 	}
 
+	public static SeriesSalesParsedDataDbDto createSeriesSalesParsedDataDbDto() {
+		SeriesSalesParsedDataDbDto dto = new SeriesSalesParsedDataDbDto();
+		dto.setSellerId(Random.id());
+		dto.setPrice(Random.price());
+		dto.setCurrency(Random.currency().toString());
+		dto.setCreatedAt(Random.date());
+		dto.setUpdatedAt(Random.date());
+		return dto;
+	}
+	
 }