Series sales form: trim URL.

Fix #661

Author: php-coder

src/main/java/ru/mystamps/web/controller/SeriesController.java

@@ -112,7 +112,7 @@ public class SeriesController {
 	}
 
 	@InitBinder("addSeriesForm")
-	protected void initBinder(WebDataBinder binder) {
+	protected void initSeriesFormBinder(WebDataBinder binder) {
 		StringTrimmerEditor editor = new StringTrimmerEditor(" ", true);
 		binder.registerCustomEditor(String.class, "michelNumbers", editor);
 		binder.registerCustomEditor(String.class, "scottNumbers", editor);
@@ -121,6 +121,11 @@ protected void initBinder(WebDataBinder binder) {
 		binder.registerCustomEditor(String.class, "comment", new StringTrimmerEditor(true));
 	}
 
+	@InitBinder("addSeriesSalesForm")
+	protected void initSeriesSalesFormBinder(WebDataBinder binder) {
+		binder.registerCustomEditor(String.class, "url", new StringTrimmerEditor(true));
+	}
+	
 	@GetMapping(Url.ADD_SERIES_PAGE)
 	public void showForm(
 		@Category @RequestParam(name = "category", required = false) LinkEntityDto category,

src/main/webapp/WEB-INF/views/series/info.html

@@ -370,7 +370,12 @@ <h5 th:text="|#{t_who_selling_series}:|">Who was selling/buying this series:</h5
 							<div class="row" togglz:active="ADD_PURCHASES_AND_SALES" sec:authorize="hasAuthority('ADD_SERIES_SALES')">
 								<div class="col-sm-12">
 									<h5 th:text="|#{t_add_info_who_selling_series}:|">Add info about selling/buying this series:</h5>
-									<form method="post" class="form-horizontal" action="info.html" th:action="@{${ADD_SERIES_ASK_PAGE}(id=${series.id})}" th:object="${addSeriesSalesForm}">
+									<form id="add-series-sales-form"
+										method="post"
+										class="form-horizontal"
+										action="info.html"
+										th:action="@{${ADD_SERIES_ASK_PAGE}(id=${series.id})}"
+										th:object="${addSeriesSalesForm}">
 
 										<div class="form-group form-group-sm" th:classappend="${#fields.hasErrors('date') ? 'has-error' : ''}">
 											<label for="date" class="control-label col-sm-3">

src/test/robotframework/series/sales/misc.robot

@@ -0,0 +1,30 @@
+*** Settings ***
+Documentation    Verify miscellaneous aspects of adding series sales
+Library          Selenium2Library
+Resource         ../../auth.steps.robot
+Suite Setup      Before Test Suite
+Suite Teardown   After Test Suite
+Force Tags       series  sales  misc
+
+*** Test Cases ***
+Url should be stripped from leading and trailing spaces
+	[Documentation]  Verify removing of leading and trailing spaces from a URL
+	Input Text       id=url  ${SPACE * 2}bad-value${SPACE * 2}
+	Submit Form      id=add-series-sales-form
+	# We can't use "Textfield Value Should Be" because it causes NPE:
+	# https://github.com/MarkusBernhardt/robotframework-selenium2library-java/issues/92
+	${value}=        Get Value  id=url
+	Should Be Equal  ${value}   bad-value
+
+*** Keywords ***
+Before Test Suite
+	[Documentation]                     Login as admin and open a page with series
+	Open Browser                        ${SITE_URL}  ${BROWSER}
+	Register Keyword To Run On Failure  Log Source
+	Log In As                           login=admin  password=test
+	Go To                               ${SITE_URL}/series/1
+
+After Test Suite
+	[Documentation]  Log out and close browser
+	Log Out
+	Close Browser