Skip to content

CategoryController: remove dependency on SeriesService by moving showInfoBySlug() method #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Jun 16, 2019 · 2 comments
Closed

CategoryController: remove dependency on SeriesService by moving showInfoBySlug() method #1053

0pdd opened this issue Jun 16, 2019 · 2 comments
Assignees
@php-coder
Labels
refactoring techdebt
Milestone
0.4.2

Comments

@0pdd
Copy link

0pdd commented Jun 16, 2019 •
edited by php-coder
Loading

The puzzle 927-dc17d3cc from #927 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/category/CategoryController.java

Line 88 in 6fc61a2

// @todo #927 CategoryController: remove dependency on SeriesService by moving showInfoBySlug() method

The puzzle was created by Slava Semushin on 16-Jun-19.
@0pdd 0pdd added the techdebt label Jun 16, 2019
0pdd referenced this issue Jun 16, 2019
@php-coder
chore: add TODO items for the next refactoring steps.
6fc61a2 
Addressed to #927

[skip ci]
@0pdd 0pdd mentioned this issue Jun 16, 2019
Closed
14 tasks
@php-coder php-coder added this to the 0.4.2 milestone Sep 9, 2019
@php-coder php-coder assigned mukeshk and unassigned mukeshk Sep 17, 2019
@mukeshk
Copy link
Contributor

mukeshk commented Sep 18, 2019

Is id duplicate of 1052?

@php-coder
Copy link
Owner

Is id duplicate of 1052?

No, they're about different classes: CategoryController vs CountryController but yes they are mostly identical.

@php-coder php-coder self-assigned this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
3 participants
@php-coder @mukeshk @0pdd