Skip to content

/country/add: allow single quote in names #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
php-coder opened this issue May 27, 2017 · 2 comments
Open

/country/add: allow single quote in names #603

php-coder opened this issue May 27, 2017 · 2 comments
Labels
area/validation kind/bug trivial
Milestone
next

Comments

@php-coder
Copy link
Owner

php-coder commented May 27, 2017 •
edited
Loading

I can't create a country with name in Russian Кот-д’Ивуар because of the validation error: Value must consist only Russian letters, hyphen or spaces.

(Perhaps we also should allow this symbol in a name in English.)
@php-coder php-coder added this to the next milestone May 27, 2017
@php-coder php-coder added the lang/ru Issue appears only in Russian localization label May 28, 2017
@php-coder php-coder changed the title /country/add: allow single quote in Russian name /country/add: allow single quote in names Mar 27, 2020
@php-coder
Copy link
Owner Author

(Perhaps we also should allow this symbol in a name in English.)

Yes, we should because there is Niuafoʻou

@php-coder php-coder self-assigned this Mar 27, 2020
@php-coder php-coder modified the milestones: next, 0.4.4 Mar 27, 2020
@php-coder php-coder removed the lang/ru Issue appears only in Russian localization label Mar 27, 2020
@php-coder
Copy link
Owner Author

It also affects import as we use the same validation rules in order to filter out candidates.

@php-coder php-coder removed their assignment Apr 2, 2020
@php-coder php-coder mentioned this issue Apr 2, 2020
Merged
@php-coder php-coder modified the milestones: 0.4.4, next May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/validation kind/bug trivial
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@php-coder