Skip to content

{Category,Country}ServiceImpl: properly handle special characters #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
php-coder opened this issue Nov 7, 2017 · 0 comments
Open

Comments

@php-coder
Copy link
Owner

We should resolve the following TODOs:

public List<Integer> findIdsWhenNameStartsWith(String name) {
Validate.isTrue(StringUtils.isNotBlank(name), "Name must be non-blank");
// TODO: escape % and _ chars in name
Validate.isTrue(
!StringUtils.containsAny(name, '%', '_'),
"Name must not contain '%' or '_' chars"
);
return categoryDao.findIdsByNamePattern(name + '%');
}

and

public List<Integer> findIdsWhenNameStartsWith(String name) {
Validate.isTrue(StringUtils.isNotBlank(name), "Name must be non-blank");
// TODO: escape % and _ chars in name
Validate.isTrue(
!StringUtils.containsAny(name, '%', '_'),
"Name must not contain '%' or '_' chars"
);
return countryDao.findIdsByNamePattern(name + '%');
}

Tech debt for 29f6dc9 (#660)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant