Fix twittercards provider type

Author: Christophe Cavanna

src/Providers/TwitterCards.php

@@ -23,7 +23,7 @@ public function __construct(Adapter $adapter)
 
         foreach ($html->getElementsByTagName('meta') as $meta) {
             $name = trim(strtolower($meta->getAttribute('name')));
-            $value = $meta->getAttribute('content');
+            $value = $meta->getAttribute('content') ?: $meta->getAttribute('value');
 
             if (empty($name) || empty($value)) {
                 continue;
@@ -62,22 +62,7 @@ public function getDescription()
      */
     public function getType()
     {
-        $type = $this->bag->get('card');
-
-        if (strpos($type, ':') !== false) {
-            $type = substr(strrchr($type, ':'), 1);
-        }
-
-        switch ($type) {
-            case 'video':
-            case 'photo':
-            case 'link':
-            case 'rich':
-                return $type;
-
-            case 'player':
-                return 'video';
-        }
+        return $this->bag->get('card');
     }
 
     /**
@@ -114,7 +99,7 @@ public function getAuthorName()
     public function getAuthorUrl()
     {
         $author = $this->getAuthorName();
-        
+
         if (!empty($author)) {
             return 'https://twitter.com/'.ltrim($author, '@');
         }

tests/CadenaserTest.php

@@ -12,7 +12,7 @@ public function testOne()
                 'title' => "Debate electoral gallego, en 'Hoy por Hoy' | Hoy por Hoy | Audio | Cadena SER",
                 'width' => 620,
                 'height' => 100,
-                'type' => 'rich',
+                'type' => 'summary_large_image',
                 'code' => '<iframe src="http://play.cadenaser.com/widget/audio/001RD010000004275766/" frameborder="0" allowTransparency="true" style="border:none;overflow:hidden;width:620px;height:100px;"></iframe>',
                 'providerName' => 'Cadena SER',
             ]

tests/GoogleTest.php

@@ -35,7 +35,7 @@ public function testPlus()
             'https://plus.google.com/u/0/+StephanHovnanian/posts/6apV9FHgo4k',
             [
                 'title' => 'Grow your business through email marketing Learn more here: http://bit.ly/Yr...',
-                'type' => 'rich',
+                'type' => 'summary_large_image',
                 'code' => '<script src="https://apis.google.com/js/plusone.js" type="text/javascript"></script><div class="g-post" data-href="https://plus.google.com/+StephanHovnanian/posts/6apV9FHgo4k"></div>',
                 'providerName' => 'Google Plus',
             ]

tests/HtmlProviderTest.php

@@ -27,7 +27,7 @@ public function testNotAllowExternalImages()
         $this->assertEmbed(
             'http://www.brothers-brick.com/2016/04/06/stunning-lego-darth-vader-mask-cleverly-hides-scenes-from-star-wars/',
             [
-                'images' => 2,
+                'images' => 1,
             ]
         );
     }
@@ -37,7 +37,7 @@ public function testAllowSomeExternalImages()
         $this->assertEmbed(
             'http://www.brothers-brick.com/2016/04/06/stunning-lego-darth-vader-mask-cleverly-hides-scenes-from-star-wars/',
             [
-                'images' => 4,
+                'images' => 3,
             ],
             [
                 'html' => [

tests/ImagesBlacklistTest.php

@@ -9,7 +9,7 @@ public function testPlainText()
         $this->assertEmbed(
             'https://alistapart.com/article/the-rich-typefaces-get-richer',
             [
-                'image' => 'https://alistapart.com/d/_made/pix/authors/photos/shoaf-headshot_120_120_c1.jpg',
+                'image' => 'https://alistapart.com/d/misc-images/bigwreath.png',
             ],
             [
                 'images_blacklist' => [
@@ -24,7 +24,7 @@ public function testPlainUrlMatch()
         $this->assertEmbed(
             'https://alistapart.com/article/the-rich-typefaces-get-richer',
             [
-                'image' => 'https://alistapart.com/d/_made/pix/authors/photos/shoaf-headshot_120_120_c1.jpg',
+                'image' => 'https://alistapart.com/d/misc-images/bigwreath.png',
             ],
             [
                 'images_blacklist' => [
@@ -39,7 +39,7 @@ public function testAuthorizedImage()
         $this->assertEmbed(
             'https://alistapart.com/article/the-rich-typefaces-get-richer',
             [
-                'image' => 'https://alistapart.com/components/assets/img/ala-logo-big.png',
+                'image' => 'https://alistapart.com/d/misc-images/bigwreath.png',
             ],
             [
                 'images_blacklist' => [

tests/PinterestTest.php

@@ -9,7 +9,7 @@ public function testOne()
         $this->assertEmbed(
             'https://www.pinterest.com/pin/106890191127977979/',
             [
-                'title' => 'Icons',
+                'title' => 'Pin by Leslie Carruthers on Icons | Pinterest | Jack nicholson, Movie stars and Movie',
                 'width' => 236,
                 'height' => 442,
                 'code' => '<a data-pin-do="embedPin" data-pin-lang="es" href="https://www.pinterest.com/pin/106890191127977979/"></a><script async defer src="//assets.pinterest.com/js/pinit.js"></script>',

tests/SlidesTest.php

@@ -10,7 +10,7 @@ public function testOne()
             'http://slides.com/alexwalker/responsive-svg/',
             [
                 'title' => 'responsive-svg',
-                'type' => 'rich',
+                'type' => 'summary_large_image',
                 'code' => '<iframe src="http://slides.com/alexwalker/responsive-svg/embed" frameborder="0" allowTransparency="true" style="border:none;overflow:hidden;width:576px;height:420px;"></iframe>',
                 'width' => 576,
                 'height' => 420,

tests/UrlBlacklistTest.php

@@ -12,7 +12,7 @@ public function testVerifyUnwanted()
         $this->assertEmbed(
             'http://glomdalen.no/skarnes',
             [
-                'url' => 'http://www.glomdalen.no?ns_campaign=frontpage&ns_mchannel=recommend_button&ns_source=facebook&ns_linkname=facebook&ns_fee=0',
+                'url' => 'https://www.glomdalen.no?ns_campaign=frontpage&ns_mchannel=recommend_button&ns_source=facebook&ns_linkname=facebook&ns_fee=0',
             ],
             [
                 'url_blacklist' => null,

tests/WordPressTest.php

@@ -10,8 +10,6 @@ public function testOne()
             'http://wordpress.tv/2013/09/06/dave-ross-optimize-image-files-like-a-pro/',
             [
                 'title' => 'Dave Ross: Optimize Image Files Like a Pro',
-                'imageWidth' => 400,
-                'imageHeight' => 224
             ]
         );
     }