Merge pull request #41 from php-school/remove-private-constructor

Remove instantiation restrictions

Author: mikeymike

src/CliMenu.php

@@ -49,11 +49,6 @@ class CliMenu
      */
     protected $open = false;
 
-    /**
-     * @var string
-     */
-    private $allowedConsumer = 'PhpSchool\CliMenu\CliMenuBuilder';
-
     /**
      * @var CliMenu|null
      */
@@ -73,12 +68,6 @@ public function __construct(
         TerminalInterface $terminal = null,
         MenuStyle $style = null
     ) {
-        $builder = debug_backtrace();
-        if (count($builder) < 2 || !isset($builder[1]['class']) || $builder[1]['class'] !== $this->allowedConsumer) {
-            throw new InvalidInstantiationException(
-                sprintf('The CliMenu must be instantiated by "%s"', $this->allowedConsumer)
-            );
-        }
 
         $this->title      = $title;
         $this->items      = $items;

src/Exception/InvalidInstantiationException.php

@@ -76,11 +76,6 @@ class MenuStyle
      */
     private $titleSeparator;
 
-    /**
-     * @var string
-     */
-    private $allowedConsumer = 'PhpSchool\CliMenu\CliMenuBuilder';
-
     /**
      * @var array
      */
@@ -152,13 +147,6 @@ public function __construct(
         $titleSeparator = '=',
         TerminalInterface $terminal = null
     ) {
-        $builder = debug_backtrace();
-        if (count($builder) < 2 || !isset($builder[1]['class']) || $builder[1]['class'] !== $this->allowedConsumer) {
-            throw new InvalidInstantiationException(
-                sprintf('The MenuStyle must be instantiated by "%s"', $this->allowedConsumer)
-            );
-        }
-
         $this->terminal        = $terminal ?: TerminalFactory::fromSystem();
         $this->bg              = $bg;
         $this->fg              = $fg;

src/MenuStyle.php

@@ -55,16 +55,6 @@ private function getMockTerminal()
         return $terminal;
     }
 
-    public function testMenuStyleCannotBeInstantiatedByDisallowedConsumers()
-    {
-        $this->setExpectedException(
-            InvalidInstantiationException::class,
-            'The MenuStyle must be instantiated by "PhpSchool\CliMenu\CliMenuBuilder"'
-        );
-
-        new MenuStyle();
-    }
-
     public function testMenuStyleCanBeInstantiatedByCliMenuBuilder()
     {
         $builder = new CliMenuBuilder();