Merge pull request #50 from php-school/terminal-cleanup

mikeymike · web-flow · commit a6170e0d9e4b · 2016-10-27T19:23:07.000+01:00
Remove windows terminal and require posix
diff --git a/composer.json b/composer.json
@@ -19,7 +19,8 @@
     },
     "require": {
         "php" : ">=5.6",
-        "beberlei/assert": "^2.4"
+        "beberlei/assert": "^2.4",
+        "ext-posix": "*"
     },
     "autoload" : {
         "psr-4" : {
diff --git a/src/Terminal/TerminalFactory.php b/src/Terminal/TerminalFactory.php
@@ -15,10 +15,6 @@ class TerminalFactory
      */
     public static function fromSystem()
     {
-        if (DIRECTORY_SEPARATOR == '\\') {
-            return new WindowsTerminal();
-        }
-
         return new UnixTerminal();
     }
 }
diff --git a/src/Terminal/WindowsTerminal.php b/src/Terminal/WindowsTerminal.php

Original file line number	Diff line number	Diff line change
`@@ -15,10 +15,6 @@ class TerminalFactory`
`15`	`15`	`*/`
`16`	`16`	`public static function fromSystem()`
`17`	`17`	`{`
`18`		`- if (DIRECTORY_SEPARATOR == '\\') {`
`19`		`- return new WindowsTerminal();`
`20`		`- }`
`21`		`-`
`22`	`18`	`return new UnixTerminal();`
`23`	`19`	`}`
`24`	`20`	`}`