Add missing error check on PEM_write_bio_PKCS7()

nielsdos · nielsdos · commit 3affdbb68381 · 2023-03-04T20:10:10.000+01:00
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -5404,7 +5404,11 @@ PHP_FUNCTION(openssl_pkcs7_verify)
 			}
 
 			if (p7bout) {
-				PEM_write_bio_PKCS7(p7bout, p7);
+				if (PEM_write_bio_PKCS7(p7bout, p7) == 0) {
+					php_error_docref(NULL, E_WARNING, "Failed to write PKCS7 to file");
+					php_openssl_store_errors();
+					RETVAL_FALSE;
+				}
 			}
 		}
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -5404,7 +5404,11 @@ PHP_FUNCTION(openssl_pkcs7_verify)`
`5404`	`5404`	`}`
`5405`	`5405`
`5406`	`5406`	`if (p7bout) {`
`5407`		`- PEM_write_bio_PKCS7(p7bout, p7);`
	`5407`	`+ if (PEM_write_bio_PKCS7(p7bout, p7) == 0) {`
	`5408`	`+ php_error_docref(NULL, E_WARNING, "Failed to write PKCS7 to file");`
	`5409`	`+ php_openssl_store_errors();`
	`5410`	`+ RETVAL_FALSE;`
	`5411`	`+ }`
`5408`	`5412`	`}`
`5409`	`5413`	`}`
`5410`	`5414`	`} else {`