Skip to content

Commit 73c4fa0

Browse files
Ma27nielsdos
authored andcommitted
ext/soap: fix make check being invoked in ext/soap
On NixOS we run `make` & `make check` inside `ext/soap` which broke the test like this: 001+ Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing WSDL: Couldn't load from 'ext/soap/tests/gh15711.wsdl' : failed to load "ext/soap/tests/gh15711.wsdl": No such file or directory 002+ in /build/php-8.3.13/ext/soap/tests/gh15711.php:29 003+ Stack trace: 004+ #0 /build/php-8.3.13/ext/soap/tests/gh15711.php(29): SoapClient->__construct('ext/soap/tests/...', Array) 005+ #1 {main} 006+ thrown in /build/php-8.3.13/ext/soap/tests/gh15711.php on line 29 Fix is to make the path dependant on `__DIR__` as it's the case in other testcases including WSDLs. Closes GH-16733.
1 parent af8ebb1 commit 73c4fa0

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

NEWS

+3
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ PHP NEWS
1111
- PDO:
1212
. Fixed memory leak of `setFetchMode()`. (SakiTakamachi)
1313

14+
- SOAP:
15+
. Fix make check being invoked in ext/soap. (Ma27)
16+
1417
07 Nov 2024, PHP 8.3.14RC1
1518

1619
- Cli:

ext/soap/tests/gh15711.phpt

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class TestSoapClient extends SoapClient {
3333
}
3434
}
3535

36-
$client = new TestSoapClient('ext/soap/tests/gh15711.wsdl', ['classmap' => ['book' => 'book']]);
36+
$client = new TestSoapClient(__DIR__ . '/gh15711.wsdl', ['classmap' => ['book' => 'book']]);
3737

3838
echo "--- Test with backed enum ---\n";
3939

0 commit comments

Comments
 (0)