Skip to content

Commit 7514b5d

Browse files
committed
Mention that zend_parse_parameters should not be tested
Also mention that --CREDITS-- section should not be included anymore. We should also change qa.php.net to stop advertising these. [ci skip]
1 parent 539b577 commit 7514b5d

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,14 @@ Submitting test scripts helps us to understand what functionality has changed.
9494
It is important for the stability and maintainability of PHP that tests are
9595
comprehensive.
9696

97+
Failure conditions of `zend_parse_parameters`, `ZEND_PARSE_PARAMETERS()` and
98+
similar functions should not be tested. These parameter parsing APIs are already
99+
extensively tested, and additional tests only complicate future modifications.
100+
101+
For newly created tests, a `--CREDITS--` section should no longer be included,
102+
as test authorship is already accurately tracked by Git. If multiple authors
103+
should be credited, the `Co-authored-by` tag in the commit message may be used.
104+
97105
## Writing documentation
98106

99107
There are two ways to contribute to the PHP manual. You can edit the manual and

0 commit comments

Comments
 (0)