Skip to content

Commit a3eb1fd

Browse files
committed
Fix GH-16388: UB when freeing a cloned _ZendTestFiber
Since there is no need to clone instances of this test class, we prevent cloning in the first place. Closes GH-16400.
1 parent e583890 commit a3eb1fd

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

ext/zend_test/fiber.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,4 +348,5 @@ void zend_test_fiber_init(void)
348348
zend_test_fiber_handlers = std_object_handlers;
349349
zend_test_fiber_handlers.dtor_obj = zend_test_fiber_object_destroy;
350350
zend_test_fiber_handlers.free_obj = zend_test_fiber_object_free;
351+
zend_test_fiber_handlers.clone_obj = NULL;
351352
}

ext/zend_test/tests/gh16388.phpt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
--TEST--
2+
GH-16388 (UB when freeing a cloned _ZendTestFiber)
3+
--EXTENSIONS--
4+
zend_test
5+
--FILE--
6+
<?php
7+
$fiber = new _ZendTestFiber(function (): int {});
8+
clone $fiber;
9+
?>
10+
--EXPECTF--
11+
Fatal error: Uncaught Error: Trying to clone an uncloneable object of class _ZendTestFiber in %s:%d
12+
%A

0 commit comments

Comments
 (0)