Fixed BC break of php_debug_zval_dump

twose · twose · commit f0b2c2cb9825 · 2020-07-11T18:30:28.000+08:00
It introduced by fixing bug #79830
diff --git a/ext/standard/var.c b/ext/standard/var.c
@@ -300,7 +300,7 @@ PHPAPI void php_debug_zval_dump(zval *struc, int level) /* {{{ */
 			GC_ADDREF(myht);
 		}
 		count = zend_array_count(myht);
-		php_printf("%sarray(%d) refcount(%u){\n", COMMON, count, Z_REFCOUNTED_P(struc) ? Z_REFCOUNT_P(struc) : 1);
+		php_printf("%sarray(%d) refcount(%u){\n", COMMON, count, Z_REFCOUNTED_P(struc) ? Z_REFCOUNT_P(struc) - 1 : 1);
 		ZEND_HASH_FOREACH_KEY_VAL_IND(myht, index, key, val) {
 			zval_array_element_dump(val, index, key, level);
 		} ZEND_HASH_FOREACH_END();

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,7 @@ PHPAPI void php_debug_zval_dump(zval struc, int level) / {{{ */`
`300`	`300`	`GC_ADDREF(myht);`
`301`	`301`	`}`
`302`	`302`	`count = zend_array_count(myht);`
`303`		`- php_printf("%sarray(%d) refcount(%u){\n", COMMON, count, Z_REFCOUNTED_P(struc) ? Z_REFCOUNT_P(struc) : 1);`
	`303`	`+ php_printf("%sarray(%d) refcount(%u){\n", COMMON, count, Z_REFCOUNTED_P(struc) ? Z_REFCOUNT_P(struc) - 1 : 1);`
`304`	`304`	`ZEND_HASH_FOREACH_KEY_VAL_IND(myht, index, key, val) {`
`305`	`305`	`zval_array_element_dump(val, index, key, level);`
`306`	`306`	`} ZEND_HASH_FOREACH_END();`