Avoid additional irrelevant constructor-related checks in UnusedPrivatePropertyRule

herndlm · ondrejmirtes · commit 2808dfad29da · 2022-05-29T14:27:24.000+02:00
diff --git a/src/Rules/DeadCode/UnusedPrivatePropertyRule.php b/src/Rules/DeadCode/UnusedPrivatePropertyRule.php
@@ -158,13 +158,7 @@ public function processNode(Node $node, Scope $scope): array
 			}
 		}
 
-		$constructors = [];
-		$classReflection = $scope->getClassReflection();
-		if ($classReflection->hasConstructor()) {
-			$constructors[] = $classReflection->getConstructor()->getName();
-		}
-
-		[$uninitializedProperties] = $node->getUninitializedProperties($scope, $constructors, $this->extensionProvider->getExtensions());
+		[$uninitializedProperties] = $node->getUninitializedProperties($scope, [], $this->extensionProvider->getExtensions());
 
 		$errors = [];
 		foreach ($properties as $name => $data) {

Original file line number	Diff line number	Diff line change
`@@ -158,13 +158,7 @@ public function processNode(Node $node, Scope $scope): array`
`158`	`158`	`}`
`159`	`159`	`}`
`160`	`160`
`161`		`- $constructors = [];`
`162`		`- $classReflection = $scope->getClassReflection();`
`163`		`- if ($classReflection->hasConstructor()) {`
`164`		`- $constructors[] = $classReflection->getConstructor()->getName();`
`165`		`- }`
`166`		`-`
`167`		`- [$uninitializedProperties] = $node->getUninitializedProperties($scope, $constructors, $this->extensionProvider->getExtensions());`
	`161`	`+ [$uninitializedProperties] = $node->getUninitializedProperties($scope, [], $this->extensionProvider->getExtensions());`
`168`	`162`
`169`	`163`	`$errors = [];`
`170`	`164`	`foreach ($properties as $name => $data) {`