InstantiationRule - call RestrictedMethodUsageExtension for constructor

Author: ondrejmirtes

src/Rules/Classes/InstantiationRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\New_;
 use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\Container;
 use PHPStan\Internal\SprintfHelper;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ParametersAcceptorSelector;
@@ -15,6 +16,8 @@
 use PHPStan\Rules\ClassNameUsageLocation;
 use PHPStan\Rules\FunctionCallParametersCheck;
 use PHPStan\Rules\IdentifierRuleError;
+use PHPStan\Rules\RestrictedUsage\RestrictedMethodUsageExtension;
+use PHPStan\Rules\RestrictedUsage\RewrittenDeclaringClassMethodReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\ShouldNotHappenException;
@@ -33,6 +36,7 @@ final class InstantiationRule implements Rule
 {
 
 	public function __construct(
+		private Container $container,
 		private ReflectionProvider $reflectionProvider,
 		private FunctionCallParametersCheck $check,
 		private ClassNameCheck $classCheck,
@@ -197,6 +201,28 @@ private function checkClassName(string $class, bool $isName, Node $node, Scope $
 				->build();
 		}
 
+		/** @var RestrictedMethodUsageExtension[] $restrictedUsageExtensions */
+		$restrictedUsageExtensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
+
+		foreach ($restrictedUsageExtensions as $extension) {
+			$restrictedUsage = $extension->isRestrictedMethodUsage($constructorReflection, $scope);
+			if ($restrictedUsage === null) {
+				continue;
+			}
+
+			if ($classReflection->getName() !== $constructorReflection->getDeclaringClass()->getName()) {
+				$rewrittenConstructorReflection = new RewrittenDeclaringClassMethodReflection($classReflection, $constructorReflection);
+				$rewrittenRestrictedUsage = $extension->isRestrictedMethodUsage($rewrittenConstructorReflection, $scope);
+				if ($rewrittenRestrictedUsage === null) {
+					continue;
+				}
+			}
+
+			$messages[] = RuleErrorBuilder::message($restrictedUsage->errorMessage)
+				->identifier($restrictedUsage->identifier)
+				->build();
+		}
+
 		$classDisplayName = SprintfHelper::escapeFormatString($classReflection->getDisplayName());
 
 		return array_merge($messages, $this->check->check(

tests/PHPStan/Rules/Classes/ForbiddenNameCheckExtensionRuleTest.php

@@ -24,6 +24,7 @@ protected function getRule(): Rule
 	{
 		$reflectionProvider = $this->createReflectionProvider();
 		return new InstantiationRule(
+			self::getContainer(),
 			$reflectionProvider,
 			new FunctionCallParametersCheck(new RuleLevelHelper($reflectionProvider, true, false, true, false, false, false, true), new NullsafeCheck(), new UnresolvableTypeHelper(), new PropertyReflectionFinder(), true, true, true, true),
 			new ClassNameCheck(

tests/PHPStan/Rules/Classes/InstantiationRuleTest.php

@@ -24,6 +24,7 @@ protected function getRule(): Rule
 	{
 		$reflectionProvider = $this->createReflectionProvider();
 		return new InstantiationRule(
+			self::getContainer(),
 			$reflectionProvider,
 			new FunctionCallParametersCheck(new RuleLevelHelper($reflectionProvider, true, false, true, false, false, false, true), new NullsafeCheck(), new UnresolvableTypeHelper(), new PropertyReflectionFinder(), true, true, true, true),
 			new ClassNameCheck(
@@ -556,4 +557,33 @@ public function testClassString(): void
 		]);
 	}
 
+	public function testInternalConstructor(): void
+	{
+		$this->analyse([__DIR__ . '/data/internal-constructor.php'], [
+			[
+				'Call to internal method InternalConstructorDefinition\Foo::__construct() from outside its root namespace InternalConstructorDefinition.',
+				21,
+			],
+		]);
+	}
+
+	public function testBug12951(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			self::markTestSkipped('Test requires PHP 8.1');
+		}
+
+		require_once __DIR__ . '/../InternalTag/data/bug-12951-define.php';
+		$this->analyse([__DIR__ . '/../InternalTag/data/bug-12951-constructor.php'], [
+			[
+				'Instantiation of internal class Bug12951Polyfill\NumberFormatter.',
+				7,
+			],
+			[
+				'Call to method __construct() of internal class Bug12951Polyfill\NumberFormatter from outside its root namespace Bug12951Polyfill.',
+				7,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/internal-constructor.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace InternalConstructorDefinition {
+	class Foo
+	{
+
+		/**
+		 * @internal
+		 */
+		public function __construct()
+		{
+
+		}
+
+	}
+
+	$a = new Foo();
+}
+
+namespace InternalConstructorUsage {
+	$a = new \InternalConstructorDefinition\Foo();
+}

tests/PHPStan/Rules/InternalTag/data/bug-12951-constructor.php

@@ -0,0 +1,8 @@
+<?php // lint >= 8.1
+
+namespace Bug12951;
+
+function (): void {
+	new \Bug12951Core\NumberFormatter();
+	new \Bug12951Polyfill\NumberFormatter();
+};

tests/PHPStan/Rules/InternalTag/data/bug-12951-define.php

@@ -12,13 +12,18 @@ class NumberFormatter extends \Bug12951Polyfill\NumberFormatter
 namespace Bug12951Polyfill {
 
 	/** @internal */
-	abstract class NumberFormatter
+	class NumberFormatter
 	{
 
 		public const NUMERIC_COLLATION = 1;
 
 		public static $prop;
 
+		public function __construct()
+		{
+
+		}
+
 		public static function doBar(): void
 		{