Regression tests

Closes phpstan/phpstan#4689
Closes phpstan/phpstan#7578
Closes phpstan/phpstan#6260

Author: ondrejmirtes

tests/PHPStan/Rules/Classes/ImpossibleInstanceOfRuleTest.php

@@ -537,4 +537,11 @@ public function testTernaryElseReportPhpDoc(): void
 		]);
 	}
 
+	public function testBug4689(): void
+	{
+		$this->checkAlwaysTrueInstanceOf = true;
+		$this->treatPhpDocTypesAsCertain = false;
+		$this->analyse([__DIR__ . '/data/bug-4689.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/bug-4689.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Bug4689;
+
+abstract class KeywordList
+{
+}
+
+abstract class AbstractPlatform
+{
+	/**
+	 * @return KeywordList
+	 */
+	final public function getReservedKeywordsList()
+	{
+		$class    = $this->getReservedKeywordsClass();
+		$keywords = new $class();
+		if (! $keywords instanceof KeywordList) {
+			throw new \Exception();
+		}
+
+		return $keywords;
+	}
+
+	/**
+	 * @throws \Exception If not supported on this platform.
+	 *
+	 * @psalm-return class-string<KeywordList>
+	 */
+	protected function getReservedKeywordsClass(): string
+	{
+		throw new \Exception();
+	}
+}

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -15,9 +15,16 @@ class StrictComparisonOfDifferentTypesRuleTest extends RuleTestCase
 
 	private bool $checkAlwaysTrueStrictComparison;
 
+	private bool $treatPhpDocTypesAsCertain = true;
+
 	protected function getRule(): Rule
 	{
-		return new StrictComparisonOfDifferentTypesRule($this->checkAlwaysTrueStrictComparison, true);
+		return new StrictComparisonOfDifferentTypesRule($this->checkAlwaysTrueStrictComparison, $this->treatPhpDocTypesAsCertain);
+	}
+
+	protected function shouldTreatPhpDocTypesAsCertain(): bool
+	{
+		return $this->treatPhpDocTypesAsCertain;
 	}
 
 	public function testStrictComparison(): void
@@ -744,4 +751,22 @@ public function testBug3019(): void
 		$this->analyse([__DIR__ . '/../../Analyser/data/bug-3019.php'], []);
 	}
 
+	public function testBug7578(): void
+	{
+		$this->checkAlwaysTrueStrictComparison = true;
+		$this->treatPhpDocTypesAsCertain = false;
+		$this->analyse([__DIR__ . '/data/bug-7578.php'], []);
+	}
+
+	public function testBug6260(): void
+	{
+		if (PHP_VERSION_ID < 80000) {
+			$this->markTestSkipped('Test requires PHP 8.0.');
+		}
+
+		$this->checkAlwaysTrueStrictComparison = true;
+		$this->treatPhpDocTypesAsCertain = false;
+		$this->analyse([__DIR__ . '/data/bug-6260.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-6260.php

@@ -0,0 +1,14 @@
+<?php // lint >= 8.0
+
+namespace Bug6260;
+
+class Foo{
+	public function __construct(
+		/** @var non-empty-array<mixed> */
+		private array $array
+	){
+		if(count($array) === 0){
+			throw new \InvalidArgumentException();
+		}
+	}
+}

tests/PHPStan/Rules/Comparison/data/bug-7578.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Bug7578;
+
+class HelloWorld
+{
+	/**
+	 * @param non-empty-array<mixed> $array
+	 */
+	public function foo(array $array): void
+	{
+		if ([] === $array) {
+			throw new \InvalidArgumentException();
+		}
+	}
+
+	/**
+	 * @param non-empty-array<mixed> $array
+	 */
+	public function foo2(array $array): void
+	{
+		if (0 === count($array)) {
+			throw new \InvalidArgumentException();
+		}
+	}
+}