Skip to content

Update framework-arduinoespressif32 package with hotfixes #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxgerhardt opened this issue Mar 6, 2021 · 7 comments
Closed

Update framework-arduinoespressif32 package with hotfixes #508

maxgerhardt opened this issue Mar 6, 2021 · 7 comments

Comments

@maxgerhardt
Copy link
Contributor

maxgerhardt commented Mar 6, 2021

After the release of the 1.0.5 Arduino-ESP32 core, a few important bugfixes have been made which also affect their usage in PlatformIO (refer commit history).

  1. Creating a project with board = firebeetle32 results in total compilation failure because of an error in the C++ code regarding duplicate pin definitions. Reported by user here and fixed in espressif/arduino-esp32@6e7cc52
  2. 3 seperate users have reported seeing warnings stemming from the c_cpp_properties.json referencing a non-existing folder, tools/sdk/include/nimbus, in the Arduino core (See reports). Fixed by my PR 2 days ago in here.

Thus I think it makes sense to repackage the Arduino-ESP32 core with these bugfixes -- I'm not sure if the Arduino core will release a 1.0.6 version for that or if they'll take longer.

@valeros
Copy link
Member

valeros commented Mar 8, 2021

Thanks for reporting, fixed directly in the framework package.

@valeros valeros closed this as completed Mar 8, 2021
@maxgerhardt
Copy link
Contributor Author

maxgerhardt commented Mar 9, 2021

@valeros, a performance degradation was noted in https://community.platformio.org/t/very-bad-performance-if-i-compile-the-example-for-esp32-cam/19730/10?u=maxgerhardt

When I compile the example in Arduino I get around 15 fps from the camera.
If I import it into Platformio I get 0.2 fps

for which the PR espressif/arduino-esp32#4911 is a fix. So I think a re-release is noted again.

But it's also reported that other basic functionality like String::replace() is broken (espressif/arduino-esp32#4920) so it seems like a rollercoaster ride right now. Maybe you can just update the package with the PR from above to fix the performance regression.

@valeros valeros reopened this Mar 10, 2021
@valeros
Copy link
Member

valeros commented Mar 10, 2021

I'm not sure that espressif/arduino-esp32#4911 is the reason for that performance degradation. I've added that changes regarding PSRAM libs in our build script before submitting a PR to the upstream repo.

@maxgerhardt
Copy link
Contributor Author

Then maybe the user had an older version of the framework-arduinoespressif32 package that caused this, hm.

@me-no-dev
Copy link

@maxgerhardt the new version 1.0.6 will be released soon and will include the fixes. @valeros do I need to let you know?

@valeros
Copy link
Member

valeros commented Mar 10, 2021

@me-no-dev Would be great.

@me-no-dev
Copy link

@valeros 1.0.6 is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants