make geom_bar() default to textposition='none'; approve new vdiffr 0.4 + plotly.js 2.0 baselines

Author: cpsievert

R/layers2traces.R

@@ -736,6 +736,11 @@ geom2trace.GeomBar <- function(data, params, p) {
     frame = data[["frame"]],
     ids = data[["ids"]],
     type = "bar",
+    # plotly.js v2.0 changed default to textposition='auto', meaning
+    # text will display by default, which makes sense for plot_ly() maybe, 
+    # but not ggplotly()
+    # https://github.com/plotly/orca/issues/374
+    textposition = "none",
     marker = list(
       autocolorscale = FALSE,
       color = toRGB(

inst/docker/Dockerfile.vtest

@@ -85,7 +85,7 @@ EXPOSE 3838
 
 ARG CRANCACHE=1
 RUN R -e "update.packages(ask=FALSE)"
-RUN R -e "remotes::install_github('r-lib/vdiffr')"
+RUN R -e "remotes::install_github('r-lib/vdiffr@v0.4.0')"
 
 # install any new dependencies, then either manage cases (the default) or run tests
 # note the workaround to get docker to run a proper exit status when there are testthat errors