Skip to content

geom_hline, geom_vline as shapes? #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tdhock opened this issue Mar 6, 2015 · 4 comments
Closed

geom_hline, geom_vline as shapes? #176

tdhock opened this issue Mar 6, 2015 · 4 comments

Comments

@tdhock
Copy link
Contributor

tdhock commented Mar 6, 2015

currently these are implemented as traces of mode "lines"

http://ropensci.github.io/plotly-test-table/tables/00a5c8df16e2b19a6629c32ed42ef3a76d6fbac6/vline-multiple.html

but should we implement them as shapes?

https://plot.ly/~etpinard/1647/plotly-shapes/

@chriddyp
Copy link
Member

yeah, definitely! the nice thing about shapes is that we can use paper coordinates, so that they can span the entire plot

@tdhock
Copy link
Contributor Author

tdhock commented Mar 31, 2015

I'm thinking about how to do this and I'm wondering ... can plotly shapes can have legend entries?

If not, then we will run into problems, since geom_hline and geom_vline can generate legends in ggplot2. In this case we should keep these as traces of mode "lines" which will result in plotly legends.

@tdhock
Copy link
Contributor Author

tdhock commented Mar 31, 2015

@alexcjohnson can plotly shapes can have legend entries?

@cpsievert
Copy link
Collaborator

In #269 I've implemented hline/vline/abline as paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants