Skip to content

Commit 11f6830

Browse files
committed
prune TODOs
1 parent 1b9b122 commit 11f6830

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

src/plots/cartesian/axes.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,6 @@ axes.autoBin = function(data, ax, nbins, is2d) {
507507
var distinctData = Lib.distinctVals(data),
508508
msexp = Math.pow(10, Math.floor(
509509
Math.log(distinctData.minDiff) / Math.LN10)),
510-
// TODO: there are some date cases where this will fail...
511510
minSize = msexp * Lib.roundUp(
512511
distinctData.minDiff / msexp, [0.9, 1.9, 4.9, 9.9], true);
513512
size0 = Math.max(minSize, 2 * Lib.stdev(data) /

test/jasmine/tests/histogram2d_test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ describe('Test histogram2d', function() {
9191

9292
// TODO: even though the binning is done on non-uniform bins,
9393
// the display makes them linear (using only y0 and dy)
94-
// when we sort out https://github.com/plotly/plotly.js/issues/1151
95-
// lets also make it display the bins with nonuniform size
94+
// Can we also make it display the bins with nonuniform size?
9695
expect(out.y0).toBe('1970-01-01 03:00');
9796
expect(out.dy).toBe(365.25 * oneDay);
9897

test/jasmine/tests/histogram_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ describe('Test histogram', function() {
156156
nbinsx: 4
157157
});
158158

159-
// Note: this gives half-day gaps between all but the first two
159+
// TODO: this gives half-day gaps between all but the first two
160160
// bars. Now that we have explicit per-bar positioning, perhaps
161161
// we should fill the space, rather than insisting on equal-width
162162
// bars?

0 commit comments

Comments
 (0)