Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 2e17994

Browse files
committedOct 2, 2019
no need to hasColorscale twice in calc step of treemap and sunburst
1 parent 1c136f4 commit 2e17994

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed
 

‎src/traces/sunburst/calc.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ var Lib = require('../../lib');
1515
var makeColorScaleFn = require('../../components/colorscale').makeColorScaleFuncFromTrace;
1616
var makePullColorFn = require('../pie/calc').makePullColorFn;
1717
var generateExtendedColors = require('../pie/calc').generateExtendedColors;
18-
19-
var Colorscale = require('../../components/colorscale');
20-
var hasColorscale = Colorscale.hasColorscale;
21-
var colorscaleCalc = Colorscale.calc;
18+
var colorscaleCalc = require('../../components/colorscale').calc;
2219

2320
var sunburstExtendedColorWays = {};
2421
var treemapExtendedColorWays = {};
@@ -190,7 +187,7 @@ exports.calc = function(gd, trace) {
190187
var scaleColor;
191188
var colors = trace.marker.colors || [];
192189
var hasColors = !!colors.length;
193-
trace._hasColorscale = hasColorscale(trace, 'marker');
190+
194191
if(trace._hasColorscale) {
195192
if(!hasColors) {
196193
colors = hasValues ? trace.values : trace._values;

‎src/traces/sunburst/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
4444
if(lineWidth) coerce('marker.line.color', layout.paper_bgcolor);
4545

4646
coerce('marker.colors');
47-
var withColorscale = hasColorscale(traceIn, 'marker', 'colors');
47+
var withColorscale = traceOut._hasColorscale = hasColorscale(traceIn, 'marker', 'colors');
4848
if(withColorscale) {
4949
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'marker.', cLetter: 'c'});
5050
}

‎src/traces/treemap/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
7373
if(lineWidth) coerce('marker.line.color', layout.paper_bgcolor);
7474

7575
coerce('marker.colors');
76-
var withColorscale = hasColorscale(traceIn, 'marker', 'colors');
76+
var withColorscale = traceOut._hasColorscale = hasColorscale(traceIn, 'marker', 'colors');
7777
if(withColorscale) {
7878
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'marker.', cLetter: 'c'});
7979
}

0 commit comments

Comments
 (0)
Please sign in to comment.