Skip to content

Commit 875aba8

Browse files
committed
fix #3839 - adding 5% padding on box/violin with set 'width'
1 parent 03b7e09 commit 875aba8

File tree

5 files changed

+667
-13
lines changed

5 files changed

+667
-13
lines changed

src/traces/box/cross_trace_calc.js

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,16 @@ function setPositionOffset(traceType, gd, boxList, posAxis) {
133133
var edge = bPos + bdPos;
134134
var edgeplus;
135135
var edgeminus;
136+
// value-space padding
137+
var vpadplus;
138+
var vpadminus;
139+
// pixel-space padding
140+
var ppadplus;
141+
var ppadminus;
142+
// do we add 5% of both sides (more logic for points beyond box/violin below)
143+
var padded = Boolean(width);
144+
// does this trace show points?
145+
var hasPts = (trace.boxpoints || trace.points) && (shownPts > 0);
136146

137147
if(side === 'positive') {
138148
pushplus = dPos * (width ? 1 : 0.5);
@@ -147,17 +157,6 @@ function setPositionOffset(traceType, gd, boxList, posAxis) {
147157
edgeplus = edgeminus = edge;
148158
}
149159

150-
// value-space padding
151-
var vpadplus;
152-
var vpadminus;
153-
// pixel-space padding
154-
var ppadplus;
155-
var ppadminus;
156-
// do we add 5% of both sides (for points beyond box/violin)
157-
var padded = false;
158-
// does this trace show points?
159-
var hasPts = (trace.boxpoints || trace.points) && (shownPts > 0);
160-
161160
if(hasPts) {
162161
var pointpos = trace.pointpos;
163162
var jitter = trace.jitter;
-354 Bytes
Loading
40.2 KB
Loading

0 commit comments

Comments
 (0)